Bug #52072
Make Port in Varnish Tasks configurable
Status: | New | Start date: | 2013-09-17 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | - | % Done: | 0% |
|
Category: | - | |||
Target version: | - |
Description
The Varnish ban and purge tasks have the port for Varnish management hardcoded. Since there might be different ports than 6082 for that, this should be configurable see patch below.
$secretFile = (isset($options['secretFile']) ? $options['secretFile'] : ''); $purgeUrl = (isset($options['purgeUrl']) ? $options['purgeUrl'] : '"ban.url ."'); $varnishadm = (isset($options['varnishadm']) ? $options['varnishadm'] : '/usr/bin/varnishadm'); $varnishport = (isset($options['varnishport']) ? $options['varnishport'] : '6082'); $varnishport = '-T 127.0.0.1:' . $varnishport; $varnishsecret = ($secretFile !== '' ? '-S ' . $secretFile . ' ' : ' '); $this->shell->executeOrSimulate($varnishadm . $varnishsecret . $varnishport . ' ' . $purgeUrl, $node, $deployment);
Btw: is there any possibility to do a pull request for the surf project, that would make fixes easier...