Task #10479

Story #11042: As Roger, I want clean and extensible JavaScript Code

Move JS Unit testing to the Testing package

Added by Rens Admiraal almost 5 years ago. Updated almost 3 years ago.

Status:Closed Start date:
Priority:Should have Due date:
Assigned To:Rens Admiraal % Done:

0%
Category:-
Target version:Base Distribution - Sprint 7

JSTesting.zip (61.6 kB) Rens Admiraal, 2010-11-15 20:39

History

#1 Updated by Rens Admiraal almost 5 years ago

  • Status changed from New to Accepted

#2 Updated by Rens Admiraal over 4 years ago

  • Status changed from Accepted to Needs Feedback

#3 Updated by Rens Admiraal over 4 years ago

I created a package for which I'm not 100% sure if the inner workings are ok, but it works, and is flexible :) Would be cool to get some feedback, will try to push it to gerrit tomorrow

#4 Updated by Rens Admiraal over 4 years ago

  • File JSTesting.zip added

Can't push it all at once ;-) So, here an attachment with the package. It's still rough, so maybe it needs to be refactored, and there's no real unit test yet.

Some other changes you've to do to get some results:

  • /Configuration/Routes.yaml
    -
  name: 'JSTesting'
  uriPattern: '<JSTestingSubroutes>'
  subRoutes:
    JSTestingSubroutes:
      package: JSTesting
  • Rename /Packages/Application/TYPO3/Tests/JavaScript/Backend/UserInterface/BreadcrumbMenu/ItemPaths.js to ItemPathTest.js
  • Add some doc comments to the Test classes of the Packages/Application/TYPO3 package:

Tests/JavaScript/Backend/Core/RegistryTest.js

/**
 * @include TYPO3:Backend/JavaScript/Core/Registry.js
 */

Tests/JavaScript/Backend/Core/UtilsTest.js

/**
 * @include TYPO3:Backend/JavaScript/Utils.js
 */

Tests/JavaScript/Backend/UserInterface/BreadcrumbMenu/ItemPathsTest.js

/**
 * @include TYPO3:Backend/JavaScript/UserInterface/Form/FormFactory.js
 * @include TYPO3:Backend/JavaScript/UserInterface/BreadcrumbMenu.js
 * @include TYPO3:Backend/JavaScript/UserInterface/BreadcrumbMenu/Util.js
 */

Tests/JavaScript/Backend/UserInterface/Form/FormFactoryTest.js

/**
 * @include TYPO3:Backend/JavaScript/UserInterface/Form/FormFactory.js
 */

#5 Updated by Rens Admiraal over 4 years ago

Note: and the package also has no package selection yet, so it's all tests at once for now

#6 Updated by Rens Admiraal over 4 years ago

Gerrit change for the TYPO3 package changes
https://review.typo3.org/#change,279

#7 Updated by Rens Admiraal over 4 years ago

  • File deleted (JSTesting.zip)

#8 Updated by Rens Admiraal over 4 years ago

New version, this one does not concatenate files which are available from within the public resources folder.

#9 Updated by Robert Lemke over 4 years ago

  • Parent task changed from #10285 to #11042

#10 Updated by Rens Admiraal over 4 years ago

  • Status changed from Needs Feedback to Closed

Not needed anymore since jasmine testrunner is now integrated, so there are now only test suites defined in the packages itself, which is a good thing.

#11 Updated by Robert Lemke almost 3 years ago

  • Project changed from Base Distribution to TYPO3.Neos

Also available in: Atom PDF