Task #10911

Task #26664: Clean up Form ViewHelpers

Task #26658: Make Form ViewHelpers consistent

Tx_Fluid_ViewHelpers_Form_AbstractFormViewHelper->renderHiddenIdentityField should be more reliable

Added by Patrick Schriner over 4 years ago. Updated almost 4 years ago.

Status:New Start date:2010-11-17
Priority:Should have Due date:
Assigned To:- % Done:

0%
Category:ViewHelpers
Target version:-
Has patch:No

Description

(Poor title)

1$name = $this->prefixFieldName($name) . '[__identity]';

The problem with this line is that if this lookup resorts to an empty string, fluid will fail during a security check:

1#1255072832: The form field name "[__identity]" is invalid. Reason: "[]" used not as last argument. 
2
3Tx_Extbase_Security_Exception_InvalidArgumentForRequestHashGeneration thrown in file W:\TYPO3Winstaller\htdocs\Dummy\typo3\sysext\extbase\Classes\Security\Channel\RequestHashService.php in line 94.

I'm pretty sure that a mistake of mine led to renderHiddenIdentityField behaving this way, yet I don't see the point in creating misleading & invalid output.

History

#1 Updated by Patrick Schriner over 4 years ago

okay, I found the reason - this happens when FormViewHelper->getFormObjectName() returns null; This happens when name is not set (which should not happen).

Still I think it could be less misleading if an error on this missing piece of configuration were raised.

#2 Updated by Sebastian Kurfuerst about 4 years ago

  • Parent task set to #26658

#3 Updated by Robert Lemke almost 4 years ago

  • Target version changed from 1.0 beta 2 to 1.0.0

#4 Updated by Robert Lemke almost 4 years ago

  • Target version deleted (1.0.0)
  • Has patch set to No

Not FLOW3 related?

Also available in: Atom PDF