Bug #11101

Pagination widget creates incorrect absolute URLs

Added by Martin Helmich over 4 years ago. Updated over 4 years ago.

Status:Resolved Start date:2010-11-26
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

100%

Category:Widgets
Target version:-
Has patch: Affected Flow version:

Description

Currently, the paginate widget creates absolute URLs. However, if your TYPO3 is installed in a subdirectory of the document root, this is apparently not respected when generating the URLs.

So, the widget creates URLS like

http://localhost/index.php... instead of
http://localhost/xyz/index.php

Is there actually any reason to use absolute URLs instead of relative ones?

Problem occurs with version 1.3.0beta1a.

Best regards,
Martin Helmich

fluid_pagination.patch Magnifier (716 Bytes) Martin Helmich, 2010-11-26 16:52

11101_pagination_v2.patch Magnifier - A 2nd version that also updates widget.uri ViewHelper (1.1 kB) Bastian Waidelich, 2010-11-26 17:25

History

#1 Updated by Bastian Waidelich over 4 years ago

  • File 11101_pagination_v2.patchMagnifier added
  • Category set to Widgets
  • Status changed from New to Accepted
  • Assigned To set to Bastian Waidelich

Does the patch you provided, fixes the issue?

#2 Updated by Martin Helmich over 4 years ago

Ah, sorry, I forgot to mention the patch. The patch fixes the issue by generating relative URLs instead of absolute ones.

However, the more I think of it... Apart from the question whether absolute or relative URLs are better, this is probably more a problem of the UriBuilder class, is it?

#3 Updated by Bastian Waidelich over 4 years ago

Martin Helmich wrote:

Ah, sorry, I forgot to mention the patch.

No problem. In the meantime it's committed and the widget.uri VH is fixed as well.

However, the more I think of it...
Apart from the question whether absolute or relative URLs are better,
this is probably more a problem of the UriBuilder class, is it?

That's right..
I'm closing this issue for now. Please open up another ticket, if you encounter other problems with the UriBuilder

#4 Updated by Bastian Waidelich over 4 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

Applied in changeset r3064

Also available in: Atom PDF