Task #11636

Task #26664: Clean up Form ViewHelpers

Task #26658: Make Form ViewHelpers consistent

Form viewhelper not functional with method GET

Added by Daniel Lienert over 4 years ago. Updated almost 2 years ago.

Status:Resolved Start date:2010-12-22
Priority:Should have Due date:
Assigned To:Christopher Hlubek % Done:

100%
Category:ViewHelpers
Target version:-
Has patch:No

Description

If the GET-method is used, only the url from action is passed to the server, but not the paramaters given there like pageId, controller, action.

These fields should be added as hidden fields in the form.

Related issues

related to Core - Bug #27415: ViewHelper Forms with method get and action parameter do ... Accepted 2011-06-13
related to TYPO3.Fluid - Bug #39456: Action URI of the form ViewHelper is not reset Resolved 2012-08-01
duplicated by TYPO3.Fluid - Bug #37459: FormViewHelper with GET method and query parameters in ac... Closed 2012-05-24

Associated revisions

Revision 488b238d
Added by Christopher Hlubek about 3 years ago

[TASK] Add query parameters for form action as hidden fields

This change makes the form viewhelper usable with method GET by adding
query parameters of the action as hidden fields to the form. Otherwise
the browser would replace them by the form values
(http://www.w3.org/TR/html401/interact/forms.html#h-17.13.3.4).

Change-Id: I9e47bf3919cdd366e3708a8fac53439b332fa5d8
Resolves: #11636
Releases: 1.1, 1.2

Revision 0c8ef04c
Added by Christopher Hlubek about 3 years ago

[TASK] Add query parameters for form action as hidden fields

This change makes the form viewhelper usable with method GET by adding
query parameters of the action as hidden fields to the form. Otherwise
the browser would replace them by the form values
(http://www.w3.org/TR/html401/interact/forms.html#h-17.13.3.4).

Change-Id: I9e47bf3919cdd366e3708a8fac53439b332fa5d8
Resolves: #11636
Releases: 1.1, 1.2

Revision 69453896
Added by Bastian Waidelich about 3 years ago

[BUGFIX] Action URI of the form ViewHelper is not reset

Form ViewHelpers store the action URI attribute for performance
reasons.
But because instances of ViewHelpers are reused, this value needs
to be reset.
Besides this removes an obsolete property "formActionUriArguments"

Change-Id: I9636b881c84285a57c5fb3225067871583c4159d
Fixes: #39456
Related: #11636
Releases: 1.1, 1.2

Revision 299ad012
Added by Bastian Waidelich about 3 years ago

[BUGFIX] Action URI of the form ViewHelper is not reset

Form ViewHelpers store the action URI attribute for performance
reasons.
But because instances of ViewHelpers are reused, this value needs
to be reset.
Besides this removes an obsolete property "formActionUriArguments"

Change-Id: I9636b881c84285a57c5fb3225067871583c4159d
Fixes: #39456
Related: #11636
Releases: 1.1, 1.2

History

#1 Updated by Sebastian Kurfuerst about 4 years ago

  • Parent task set to #26658

#2 Updated by Robert Lemke almost 4 years ago

  • Target version changed from 1.0 beta 2 to 1.0.0

#3 Updated by Karsten Dambekalns almost 4 years ago

  • Target version deleted (1.0.0)

#4 Updated by Bastian Waidelich about 3 years ago

  • Priority changed from Must have to Should have
  • Has patch set to No

Some more comments from #37459 :

If the form viewhelper is used with method="GET" and the action attribute that is built (given with actionUri or using the URI builder) contains query paramters, they will be lost on form submission (http://www.w3.org/TR/html401/interact/forms.html#h-17.13.3.4).

The form viewhelper should parse query parameters in the action URI and prepend them as hidden fields in the form to pass them to the request that is submitted.

#5 Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11571

#6 Updated by Christopher Hlubek about 3 years ago

  • Assigned To set to Christopher Hlubek

#7 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11571

#8 Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11571

#9 Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11571

#10 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12209

#11 Updated by Christopher Hlubek about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12209

#13 Updated by Christopher Hlubek about 3 years ago

  • Status changed from Under Review to Resolved

#14 Updated by Nicolas Forgeot over 2 years ago

the correction is deployed in version 1.4 ?

I have the same problem with a TYPO3 6.0.

#15 Updated by Martin Terber about 2 years ago

Bug is still present in fluid 'version' => '6.1.0'

#16 Updated by Bastian Waidelich about 2 years ago

Mateng no-lastname-given wrote:

Bug is still present in fluid 'version' => '6.1.0'

@Mateng & @Nicolas:
This is the issue tracker for the Fluid package for Flow. For the Fluid extension please refer to http://forge.typo3.org/projects/typo3v4-fluid/issues

#17 Updated by Marc Bastian Heinrichs almost 2 years ago

Any suggestions how to handle this in CMS fluid in combination with realurl?

Btw.: you deprecated setFormActionUri, but still call it in render()

Also available in: Atom PDF