Feature #11771

Check for write-permissions before installation

Added by Steffen Gebert over 4 years ago. Updated over 1 year ago.

Status:Resolved Start date:2010-12-29
Priority:Could have Due date:
Assigned To:Alexander Opitz % Done:

100%
Category:Install Tool Spent time: -
Target version:-
PHP Version: Sprint Focus:
Complexity:

Description

What do you think of checking for write-permissions on typo3conf/ and typo3temp/ at the very first place?

This also enables to use the FIRST_INSTALL file and doesn't show the missing-ENABLE_INSTALL_TOOL warning (and then the "I want to write to typo3temp" and then the "I want to write to typo3conf/localconf.php").

So this would require a change of the core behavior, but I would call it way more user-friendly instead of interpreting the meaning of error messages one by one.

11771.diff Magnifier (4.1 kB) Steffen Gebert, 2011-06-02 23:24

forge_11771.png (24.1 kB) Oliver Hader, 2011-12-19 19:45

Related issues

related to Core - Bug #31255: CF: Could not create directory Resolved 2011-10-25
related to Core - Bug #53464: Migrate all file relations hangs after wrong permissions Closed 2013-11-08
related to Introduction Package - Bug #12870: FIRST_INSTALL not working? Resolved 2011-02-08
related to Core - Bug #46602: If typo3temp is not create-/writeable we get a uncaught e... Closed 2013-03-23
related to Core - Bug #42907: Installation Exceptions should look nice Closed 2012-11-13
related to Core - Feature #43477: Better error handling on dummy without permissions (inste... Closed 2012-11-30
related to Core - Bug #47066: If typo3conf is not writeable we get a uncaught exception... Closed 2013-04-09
duplicated by Core - Feature #12872: Initial check screen for writable paths Closed 2011-02-08

Associated revisions

Revision e7cf5501
Added by Alexander Opitz over 1 year ago

[BUGFIX] Catch all errors while starting installer

While initializing the installer it can happen that
Exceptions are thrown. As there is no ExceptionHandler
initialized yet, we get a white page and the Fatal error
will be logged.

Mostly it is the problem that typo3conf and/or typo3temp
isn't writeable. But it might something else which throws
an exception.

This patch catches the exception in the initializing
process and shows a page in the layout of the installer.
It shows the exception message, a first hint for the maybe
write permissions problem and a link with the exception number.

Resolves: #11771
Releases: 6.1
Change-Id: Ib99860054b727907a9a84bdfd3e35fe3f2eebe00
Reviewed-on: https://review.typo3.org/23219
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Ben van 't Ende over 4 years ago

  • Category set to Install process
  • Status changed from New to Under Review
  • Priority changed from Should have to Could have
  • Target version set to 4.6

#2 Updated by Steffen Gebert about 4 years ago

Working patch attached. I only have to think of the situation, when the fileadmin/ directory has been renamed..

#3 Updated by Steffen Gebert about 4 years ago

  • Tracker changed from Bug to Feature
  • Project changed from Introduction Package to Core
  • Category deleted (Install process)
  • Assigned To set to Steffen Gebert
  • Target version deleted (4.6)

#4 Updated by Steffen Gebert about 4 years ago

  • Subject changed from Check for write-permissions first to Check for write-permissions before installation
  • Category set to Install Tool
  • TYPO3 Version set to 4.6

#5 Updated by Steffen Ritter over 3 years ago

  • Target version set to 4.7.0-alpha2

#6 Updated by Steffen Ritter over 3 years ago

Mind to push that to Gerrit? Or Should I?

#7 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7396

#8 Updated by Oliver Hader over 3 years ago

Looks like this now:

#9 Updated by Steffen Gebert over 3 years ago

#31255 is a new point, where the installation breaks because of insufficient rights. This check should be somewhere before the Caching Framework dies. See #31255 for a strack trace.

#10 Updated by Oliver Hader over 3 years ago

  • Target version changed from 4.7.0-alpha2 to 4.7.0-alpha3

#11 Updated by Steffen Ritter over 3 years ago

  • Target version changed from 4.7.0-alpha3 to 4.7.0-beta1

#12 Updated by Steffen Ritter over 3 years ago

  • Target version deleted (4.7.0-beta1)

#13 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7396

#14 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/7396

#15 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/7396

#16 Updated by Alexander Opitz over 2 years ago

  • TYPO3 Version changed from 4.6 to 6.1

#17 Updated by Kay Strobach over 2 years ago

why chmod 777 ??? -> isn't it better to chgrp www-data ? and chmod 770?

Thanks

#18 Updated by Kay Strobach over 2 years ago

why chmod 777 ??? -> isn't it better to chgrp www-data ? and chmod 770?

Thanks

#19 Updated by Alexander Opitz about 2 years ago

Hi Kay,

here is nothing about chmod 777, so did you post to false issue?

#20 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/7396

#21 Updated by Alexander Opitz about 2 years ago

  • Assigned To changed from Steffen Gebert to Alexander Opitz
  • Target version set to 6.2.0

#22 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/7396

#23 Updated by Gerrit Code Review about 2 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/7396

#24 Updated by Gerrit Code Review about 2 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/7396

#25 Updated by Gerrit Code Review about 2 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/7396

#26 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23219

#27 Updated by Wouter Wolters almost 2 years ago

  • Target version deleted (6.2.0)

#28 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23219

#29 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23219

#30 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23219

#31 Updated by Alexander Opitz over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF