Task #12204

Story #11958: Check loose ends in FLOW3

Improve Fluid Resource Interceptor Performance

Added by Sebastian Kurfuerst over 4 years ago. Updated about 4 years ago.

Status:Resolved Start date:
Priority:Should have Due date:
Assigned To:Sebastian Kurfuerst % Done:

0%

Category:-
Target version:1.0 beta 1 Estimated time:0.00 hour

Description

While I profiled the welcome package, I noticed that much time was spent during preg_match -- see attached screenshot "before". A quick drill-down showed that this was almost fully spent in the resource interceptor of fluid (99,2% of the time).

That's why I decided to optimize the RegEx a little bit, and add an early return which covers most cases, leading to a much improved behavior (see attached screenshot "after").

before.png - Before profiling (178.2 kB) Sebastian Kurfuerst, 2011-01-14 08:58

after-1.png - After profiling (168.7 kB) Sebastian Kurfuerst, 2011-01-14 08:58

4d3000a0eb439.xhprof_foo - xhprof profile "before" (489.2 kB) Sebastian Kurfuerst, 2011-01-14 08:58

4d2fff204c9bd.xhprof_foo - xhprof profile "after" (488.6 kB) Sebastian Kurfuerst, 2011-01-14 08:58

History

#1 Updated by Sebastian Kurfuerst over 4 years ago

  • Status changed from New to Accepted

#3 Updated by Sebastian Kurfuerst over 4 years ago

  • Status changed from Accepted to Under Review

#4 Updated by Sebastian Kurfuerst over 4 years ago

  • Status changed from Under Review to Resolved
  • Estimated time set to 0.00
  • Remaining (hours) set to 0.0

Also available in: Atom PDF