TYPO3 Flow Base DistributionPackagesApplications

Bug #12372

Wrong property declaration in message API

Added by Steffen Müller over 4 years ago. Updated over 4 years ago.

Status:Resolved Start date:2011-01-19
Priority:Should have Due date:
Assigned To:Karsten Dambekalns % Done:

100%
Category:-
Target version:-

Description

The visibility declaration in the Message class is "var", but should be "protected":

class t3lib_mail_Message extends Swift_Message {
  var $mailer;
  var $sent = FALSE;
  var $failedRecipients = array();

12372.diff Magnifier (616 Bytes) Steffen Müller, 2011-01-19 15:04

12372_v2.diff Magnifier (718 Bytes) Steffen Müller, 2011-01-19 15:12

Related issues

related to Core - Bug #24663: Wrong property declaration in t3lib_mail_Message API Closed 2011-01-19

Associated revisions

Revision 3daf5ae1
Added by Karsten Dambekalns over 4 years ago

[BUGFIX] Replace var with protected keyword

Fixes: #12372
Change-Id: I7511a12935a6eff29593c0c19c895c625a703ceb

History

#1 Updated by Steffen Müller over 4 years ago

Appended patch fixes the issue.

#2 Updated by Steffen Müller over 4 years ago

Improved patch which also changes the annotations.

#3 Updated by Karsten Dambekalns over 4 years ago

  • Project changed from TYPO3.SwiftMailer to Core

#4 Updated by Ernesto Baschny over 4 years ago

  • Project changed from Core to TYPO3.SwiftMailer
  • Assigned To set to Karsten Dambekalns

This has been fixed in v4 core already (#24663). This issue is to forward-port the fix also to the SwiftMailer package from FLOW3. If it has been fixed there already, just close the issue. Thanks!

#5 Updated by Karsten Dambekalns over 4 years ago

  • Status changed from New to Accepted

Now I got it.

#6 Updated by Karsten Dambekalns over 4 years ago

  • Status changed from Accepted to Under Review

#7 Updated by Mr. Hudson over 4 years ago

Patch set 1 of change I7511a12935a6eff29593c0c19c895c625a703ceb has been pushed to the review server.
It is available at http://review.typo3.org/1307

#8 Updated by Mr. Hudson over 4 years ago

Patch set 2 of change I7511a12935a6eff29593c0c19c895c625a703ceb has been pushed to the review server.
It is available at http://review.typo3.org/1307

#9 Updated by Mr. Hudson over 4 years ago

Patch set 3 of change I7511a12935a6eff29593c0c19c895c625a703ceb has been pushed to the review server.
It is available at http://review.typo3.org/1307

#10 Updated by Karsten Dambekalns over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF