Bug #13333

AOP for methods with references do not work.

Added by Martin Eisengardt over 4 years ago. Updated about 3 years ago.

Status:Resolved Start date:2011-02-24
Priority:Should have Due date:
Assigned To:Christian Müller % Done:

100%

Category:AOP
Target version:TYPO3 Flow Base Distribution - 1.0.5
PHP Version: Complexity:
Has patch:No Affected Flow version:FLOW3 1.0.0

Description

Tried to log a method call to GenericPod\Backend->storeObject (fourth parameter is a reference to an array)

//    
//    /**
//     * logging
//     *
//     * @param \F3\FLOW3\AOP\JoinPointInterface $joinPoint The current join point
//     * @return void
//     * @around method(F3\FLOW3\Persistence\Backend\GenericPdo\Backend->storeObject())
//     */
//    public function logStoreObject(\F3\FLOW3\AOP\JoinPointInterface $joinPoint)
//    {
//        $object = $joinPoint->getMethodArgument('object');
//        $id = $joinPoint->getMethodArgument('identifier');
//        $parent = $joinPoint->getMethodArgument('parentIdentifier');
//        $data = $joinPoint->getMethodArgument('objectData');
//        
//        $this->logger->log('GenericPDOBackend->storeObject(['.get_class($object).'], '.$id.', '.$parent.', ...)');
//        
//        $result = $joinPoint->getAdviceChain()->proceed($joinPoint);
//        return $result;
//    }

error/exception:

Warning: Parameter 4 to F3\FLOW3\Persistence\Backend\GenericPdo\Backend_AOPProxy_Development::storeObject() expected to be a reference, value given in


Related issues

related to TYPO3.Flow - Bug #30914: Proxy methods for methods with "by reference" return type... Resolved 2011-10-14

Associated revisions

Revision fa086785
Added by Christian Müller over 3 years ago

[BUGFIX] Proxy methods with referenced arguments should work

Arguments given by reference would result in an exception if
the method was proxied due to AOP.

Change-Id: I647006669608a98a4fb9bc289d89c3c801502df1
Fixes: #30914
Fixes: #13333
Releases: 1.0,1.1

Revision fed005bf
Added by Christian Müller over 3 years ago

[BUGFIX] Proxy methods with referenced arguments should work

Arguments given by reference would result in an exception if
the method was proxied due to AOP.

Change-Id: I647006669608a98a4fb9bc289d89c3c801502df1
Fixes: #30914
Fixes: #13333
Releases: 1.0,1.1

History

#1 Updated by Robert Lemke over 4 years ago

  • Category set to AOP
  • Status changed from New to Accepted
  • Assigned To set to Robert Lemke
  • Target version set to 1.0 beta 1

#2 Updated by Sebastian Kurfuerst almost 5 years ago

  • Target version changed from 1.0 beta 1 to 1.0 beta 2

what's the status here? Moving to beta2.

#3 Updated by Robert Lemke almost 4 years ago

  • Target version changed from 1.0 beta 2 to 1.0.0

#4 Updated by Karsten Dambekalns almost 4 years ago

  • Target version deleted (1.0.0)

#5 Updated by Karsten Dambekalns almost 4 years ago

  • Affected Flow version set to FLOW3 1.0.0

#6 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9651

#7 Updated by Christian Müller over 3 years ago

  • Assigned To changed from Robert Lemke to Christian Müller
  • Has patch set to No

#8 Updated by Christian Müller over 3 years ago

  • Target version set to 1.0.4

#9 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9651

#10 Updated by Christian Müller over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/10248

#12 Updated by Karsten Dambekalns over 3 years ago

  • Target version changed from 1.0.4 to 1.0.5

#13 Updated by Karsten Dambekalns about 3 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF