Bug #13979

Problem with deleting package

Added by Dawid over 4 years ago. Updated over 4 years ago.

Status:Resolved Start date:2011-03-22
Priority:Could have Due date:
Assigned To:Karsten Dambekalns % Done:

100%
Category:Package
Target version:TYPO3 Flow Base Distribution - 1.0 beta 1
PHP Version: Complexity:
Has patch: Affected Flow version:

Description

Looks like there is some kind of problem with recursive deleting files.

After typing ./flow3 package delete Packagekey i receive

Uncaught Exception in FLOW3 #1: Warning: rmdir(/var/www/flow/public/Packages/Application/Offices/Resources/Private/Templates/Office): Directory not empty in /var/www/flow/public/Packages/Framework/FLOW3/Classes/Utility/Files.php line 140
thrown in file Packages/Framework/FLOW3/Classes/Error/ErrorHandler.php
in line 82

Offices is my test package key.
It looks like it is tring to use rm with out -R parameter

Related issues

related to TYPO3.Flow - Bug #25472: Files::emptyDirectoryRecursively() cannot remove director... Resolved 2011-03-30

Associated revisions

Revision ee876fda
Added by Karsten Dambekalns over 4 years ago

[BUGFIX] (Package) Clear message when package dir cannot be deleted

When the removal of a package directory fails, throw an exception that
hints at file permissions as a possible cause.

Fixes: #13979
Change-Id: I445530204cbe7413879b3130610ebc8ba3ab685f

History

#1 Updated by Karsten Dambekalns over 4 years ago

  • Category set to Package
  • Status changed from New to Accepted
  • Assigned To set to Karsten Dambekalns
  • Priority changed from Must have to Could have

No, it tries to do the right thing, but fails to remove some items due to permission problems. Thus some files are left and the rmdir() fails.

Solution: catch those errors and emit a more helpful message.

#2 Updated by Karsten Dambekalns over 4 years ago

  • Target version set to 1.0 beta 1

Another possible cause: there is a .svn or .git directory in your package directory. That cannot be deleted right now, see #25472.

#3 Updated by Mr. Hudson over 4 years ago

Patch set 1 of change I445530204cbe7413879b3130610ebc8ba3ab685f has been pushed to the review server.
It is available at http://review.typo3.org/1326

#4 Updated by Mr. Hudson over 4 years ago

Patch set 2 of change I445530204cbe7413879b3130610ebc8ba3ab685f has been pushed to the review server.
It is available at http://review.typo3.org/1326

#5 Updated by Karsten Dambekalns over 4 years ago

  • Status changed from Accepted to Under Review

#6 Updated by Dawid over 4 years ago

Hi guys, thanks for checking.

First of all..no .svn or .git folders where there. For sure

Priviliges also shouldn`t be a problem because all Packages for test had chmod 777 recursivly for all folders. So I think that those two basic things ain`t relevant

#7 Updated by Mr. Hudson over 4 years ago

Patch set 3 of change I445530204cbe7413879b3130610ebc8ba3ab685f has been pushed to the review server.
It is available at http://review.typo3.org/1326

#8 Updated by Mr. Hudson over 4 years ago

Patch set 4 of change I445530204cbe7413879b3130610ebc8ba3ab685f has been pushed to the review server.
It is available at http://review.typo3.org/1326

#9 Updated by Karsten Dambekalns over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF