Bug #21769

Hardcoded BE path in typo3/sysext/install/updates/class.tx_coreupdates_installnewsysexts.php

Added by Christian Lerrahn over 5 years ago. Updated about 2 years ago.

Status:Rejected Start date:2013-06-24
Priority:Should have Due date:2013-06-24
Assigned To:Alexander Opitz % Done:

0%
Category:- Spent time: -
Target version:-
TYPO3 Version:4.3 Is Regression:
PHP Version:5.3 Sprint Focus:
Complexity:

Description

In typo3/sysext/install/updates/class.tx_coreupdates_installnewsysexts.php there are two places where the BE path is hardcoded.

(issue imported from #M12881)

hardcoded-BE-path-in-installer.diff Magnifier (2 kB) Administrator Admin, 2009-12-02 12:53

Related issues

follows Core - Task #49162: Rewrite install tool Resolved 2011-10-30

History

#1 Updated by Xavier Perseguers over 3 years ago

  • Assigned To deleted (Steffen Kamper)
  • Target version deleted (0)

#2 Updated by Alexander Opitz about 2 years ago

  • Status changed from Accepted to Needs Feedback

The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?

#3 Updated by Riccardo De Contardi about 2 years ago

as far as I can see:

The lines reported in the attached .diff file are still present in TYPO3 4.5.20 and 4.7.7;
in TYPO3 6.1:

- the file typo3/sysext/install/updates/class.tx_coreupdates_installnewsysexts.php does not exist

- I've found this line in /typo3/sysext/install/Classes/CoreUpdates/InstallSysExtsUpdate.php:

    /**
     * @var string
     */
    protected $extEmConfPath = 'typo3/sysext/@extensionKey/ext_emconf.php';

Is it related?
BTW in the same file there are some hardcoded labels in english ;)

#4 Updated by Alexander Opitz about 2 years ago

  • Status changed from Needs Feedback to New
  • Assigned To set to Alexander Opitz

#5 Updated by Christian Kuhn about 2 years ago

  • Status changed from New to Rejected

Mhh ... typo3/ path segment is hardcoded at lots of places. I also see no real point in changing that and using the constant instead. With the path put as default in the protected property in 6.2, it is also not possible to use the constant there (php does not allow this). Only solution would be to add a __construct compiling the path, which actually only makes the code more complex and harder to understand.

I'd vote for staying with this "hardcoded" path segment at that point ...

I'll close the issue with won't fix. Please re-open if this is really important for you for whatever reason.

Also available in: Atom PDF