Bug #22706

t3lib_iconWorks::getIconImage is not needed anymore

Added by Steffen Ritter about 5 years ago. Updated over 2 years ago.

Status:Resolved Start date:2010-05-24
Priority:Should have Due date:
Assigned To:Steffen Ritter % Done:

100%

Category:- Spent time: -
Target version:-
TYPO3 Version:4.4 Is Regression:
PHP Version:5.1 Sprint Focus:
Complexity:

Description

t3lib_iconWorks::getIconImage is not needed anymore since this functionality is replaced by t3lib_iconWorks::getSpriteIconForRecord...

depreciate it, call depreciation log and return result of new function

(issue imported from #M14467)


Related issues

related to Core - Bug #22033: SPRITE ICON API Closed 2010-01-31
related to Core - Bug #17807: noIconProc not needed anymore? Closed 2010-06-01
related to Core - Bug #23043: Not all getIconImage calls in Core are replaced by getSpr... Closed 2010-06-29
related to Core - Bug #42817: t3lib_iconworks::getIconImage for pages returns a broken ... Closed 2012-11-09

Associated revisions

Revision 1b1dda4a
Added by Benjamin Mack over 2 years ago

[TASK] Deprecate IconUtility::getIconImage

IconUtility::getIconImage
is not used anymore in the core, so deprecated this function.

Change-Id: Ic9d33160d0ca802dcdec929400f7919e39c8aec8
Resolves: #22706
Releases: 6.1
Reviewed-on: https://review.typo3.org/12903
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

History

#1 Updated by Steffen Kamper about 5 years ago

Committed to trunk rev 7901

#2 Updated by Steffen Kamper about 5 years ago

reopened as there are missing parameters

#3 Updated by Steffen Ritter about 5 years ago

after 14923 there is no core usage anymore ...
therefore at least the deprecation is possible

fallback without parsing parameters might be discussable.
i personally think since we do not loose functionality in core, a "lightway" fallback should be enough

#4 Updated by Steffen Ritter almost 5 years ago

postponed to 4.6

#5 Updated by Xavier Perseguers about 4 years ago

  • Target version changed from 1081 to 1238

#6 Updated by Georg Ringer about 4 years ago

function is used multiple times in:
- EXT:version/ws/class.wslib_gui.php
- EXT:version/ws/index.php

so no chance to deprecate that before changing code somewhere else

#7 Updated by Oliver Hader about 4 years ago

  • Target version changed from 1238 to 1281

#8 Updated by Xavier Perseguers about 4 years ago

  • Target version changed from 1281 to 4.6.0-beta1

#9 Updated by Tolleiv Nietsch about 4 years ago

go ahead files in EXT:version are not in place anymore

#10 Updated by Xavier Perseguers about 4 years ago

  • Target version changed from 4.6.0-beta1 to 4.6.0-beta2

#11 Updated by Xavier Perseguers almost 4 years ago

  • Target version changed from 4.6.0-beta2 to 4.7.0

#12 Updated by Steffen Ritter over 3 years ago

  • Target version deleted (4.7.0)

#13 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12903

#14 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12903

#15 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12903

#16 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12903

#17 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12903

#18 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12903

#19 Updated by Benjamin Mack over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF