Feature #23051: Improve t3lib_DB::fullQuoteArray - Core - TYPO3 Forge

Core Indexed Search Linkvalidator Release Cycles Team Resources Workspaces & Versioning TYPO3 CMS Usability Team Community Extensions Distributions Feature-Requests TYPO3 6.2 Projects (+)(Archived Projects)

Feature #23051

Improve t3lib_DB::fullQuoteArray

Added by Helmut Hummel about 5 years ago. Updated 7 months ago.

Status:

New

Start date:

2010-06-30

Priority:

Should have

Due date:

Assigned To:

% Done:

Category:

Spent time:

Target version:

7.4 (Backend)

PHP Version:

5.2

Sprint Focus:

Complexity:

Description

fullQuoteArray only quotes the field values, not the field names

OTRS
2010011810000016: Sebastian Böttger
(issue imported from #M14937)

fullQuoteStr.diff (966 Bytes) Administrator Admin, 2010-06-30 10:57

quoteFieldsInArray.diff (620 Bytes) Administrator Admin, 2010-06-30 14:28

14937_caching_core.diff (7.7 kB) Administrator Admin, 2010-07-17 16:20

14937_caching_dbal.diff (7.1 kB) Administrator Admin, 2010-07-17 16:20

14937_fullQuoteArray.diff (693 Bytes) Administrator Admin, 2010-07-17 16:36

Related issues

History

#1 Updated by Helmut Hummel about 5 years ago

Just an Idea how this function could be improved (fullQuoteStr.diff)

#2 Updated by Susanne Moog about 5 years ago

Steffen Ritter:
"the function getColumns already exists in t3lib_db called admin_get_fields the task would have immense performance impact but: dbal already cached all these information (internal cache of all db fields available)
it would be an little amount of time (minutes) to move this caching from dbal to core t3lib_db with the moved cache +1"

#3 Updated by Xavier Perseguers about 5 years ago

14937_caching_*.diff patches move cache of all DB fields from DBAL to Core

#4 Updated by Xavier Perseguers about 5 years ago

14937_fullQuoteArray.diff is the patch to be used for this bug once 14937_caching_*.diff patches have been applied. This ensures that it uses cached information and as such does not "cost" anything!

#5 Updated by Xavier Perseguers about 5 years ago

Just as info, in order to test, you may omit the DBAL patch, it only moves stuff out of it...

#6 Updated by Helmut Hummel over 4 years ago

Hi Xavier,
I'd like to give this one a bump.

By reading I have the following comments:

If I get it right, the sqlparser and the installtool is (only) needed to create the cache entries. So how about not instanciating them in the constructor, but only when needed during the caching.

Instead of reading all keys with array_keys() into a new array and then checking with in_array(), I would suggest to use arra_key_exists directly.

Other than that it looks good to me and it would be great to get this into 4.5