Bug #23559

Sprite API: Missing icon "Undelete and edit" in DB Check

Added by Chris topher almost 5 years ago. Updated about 1 month ago.

Status:Closed Start date:2010-09-18
Priority:Should have Due date:
Assigned To:- % Done:

0%

Category:- Spent time: -
Target version:-
TYPO3 Version:4.5 Is Regression:No
PHP Version:5.3 Sprint Focus:
Complexity:

Description

In the module "DB Check", option Fullsearch you can search the different database records.
When you choose Advanced Search and check "Show even deleted entries" these entries are shown. Only the icon "Undelete and edit" is missing. You see that in the screenshot, the red question mark.

(issue imported from #M15739)

Missing-icon-for-undelete-and-edit.gif (4.8 kB) Administrator Admin, 2010-09-18 02:52

20110114_RFC_15739.diff Magnifier (1.2 kB) Administrator Admin, 2011-01-14 12:15

20110114_RFC_15739_2.diff Magnifier (873 Bytes) Administrator Admin, 2011-01-14 13:02


Related issues

related to Core - Bug #22704: Make use of the new Sprite API throughout the TYPO3 Core ... Resolved 2010-05-24
related to Core - Bug #24835: Missing and old Icons in "DB check -> Record Statistics" Closed 2011-01-26

History

#1 Updated by Ernesto Baschny over 4 years ago

Still present in beta2.

#2 Updated by Patrick Broens over 4 years ago

Added a patch.

t3lib_iconWorks::getSpriteIcon was called with the wrong iconname. The icon was already present.

#3 Updated by Patrick Broens over 4 years ago

The icon for 'undelete only' has the name 'actions-edit-restore'.
The icon for 'undelete and edit' now has the name
'actions-edit-undelete-edit' because it was already registered with that
name. It would be nicer to have the name 'actions-edit-restore-edit' so
both use 'restore', but it might be possible extensions are using this
icon as well, and they will break if we change the name of the icon
itself. What do you think?

#4 Updated by Patrick Broens over 4 years ago

Added a second patch which changes the name of the icon itself as mentioned in the notes above. But this change might break extensions which use this icon.

How to test:
Change the name of the file
typo3/sysext/t3skin/images/icons/actions/edit-undelete-edit.png
to
typo3/sysext/t3skin/images/icons/actions/edit-restore-edit.png
and apply the patch

#5 Updated by Alexander Opitz over 1 year ago

  • Status changed from Accepted to Needs Feedback
  • Target version deleted (0)
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.1.7)?

#6 Updated by Chris topher about 1 year ago

Issue still present in 6.2. Should be easy to fix since the patch is already there...

#7 Updated by Alexander Opitz about 1 year ago

So can you bring the patches into Gerrit please?

#8 Updated by Alexander Opitz 7 months ago

ping

#9 Updated by Alexander Opitz about 1 month ago

  • Status changed from Needs Feedback to Closed
  • Assigned To deleted (Patrick Broens)

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Also available in: Atom PDF