Bug #23697

locallangXMLOverride should not distinguish between paths ending with php and xml (like readLLfile does)

Added by Andreas Kiessling almost 5 years ago. Updated over 4 years ago.

Status:Closed Start date:2010-10-09
Priority:Should have Due date:
Assigned To:Steffen Gebert % Done:

0%

Category:- Spent time: -
Target version:-
TYPO3 Version:4.4 Is Regression:
PHP Version:4.3 Sprint Focus:
Complexity:

Description

With locallangXMLOverride you are able to override any label. A lot of backend labels are still configured like this:

'title' => 'LLL:EXT:lang/locallang_tca.php:pages',

To override such a label, you have to use
$GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']['EXT:lang/locallang_tca.php'][] = 'PATH_TO_MY_XML';
whereas the label is stored in an locallang_tca.xml file.

readLLfile removes the file extension when it is called with a filepath, checks if there is a xml file and uses that one. If there is no xml, it checks for a php file.

When you use locallangXMLOverride however, you need to set the filepath not to the actual path of the xml file, but to the path with which readLLfile is called. This is inconsistent and so you have to include two override statements to make sure to catch all labels.

Solution: check if there are overrides set for php and xml paths

Note: patch is for current trunk, but applies to 4.4 with some offset

(issue imported from #M15942)

15942.patch Magnifier (1.3 kB) Administrator Admin, 2010-10-09 18:47

15942_v2.patch Magnifier (1.3 kB) Administrator Admin, 2010-10-11 20:55


Related issues

related to Core - Feature #20955: Override FE labels with XML files Resolved 2009-08-30

History

#1 Updated by Steffen Gebert almost 5 years ago

Looks good by reading, Andreas!
Just throw it to the core list, thanks!

#2 Updated by Andreas Kiessling almost 5 years ago

Pending in core list with v2 (better naming for variable)

#3 Updated by Steffen Gebert almost 5 years ago

Committed to trunk rev. 9068

Thanks for your contribution, Andreas!

#4 Updated by Susanne Moog over 4 years ago

  • Target version deleted (4.5.0)

Also available in: Atom PDF