Bug #23791

After #23766: New layout and labels for tt_content show palette labels without content

Added by Chris topher almost 5 years ago. Updated over 4 years ago.

Status:Closed Start date:2010-10-19
Priority:Should have Due date:
Assigned To:Ernesto Baschny % Done:

0%

Category:- Spent time: -
Target version:-
TYPO3 Version:4.5 Is Regression:
PHP Version:5.3 Sprint Focus:
Complexity:

Description

After #23766 palette labels are displayed, although there is no option in the palette.
So you see a palette "headline", but no option below. This does not make sense; remove the palette label in that case!

See screenshot.

(issue imported from #M16065)

Header-without-content.gif (4.5 kB) Administrator Admin, 2010-10-19 18:18

palette_headers.diff Magnifier (3.1 kB) Administrator Admin, 2010-10-20 14:30


Related issues

related to Core - Feature #23766: Implement new layout and labels for tt_content as result ... Closed 2010-10-17

History

#1 Updated by Jo Hasenau almost 5 years ago

Actually these are not section headers but palette labels.

16031 just makes use of default TCA syntax, that already offered labels for palettes by using this code:

--palette--;Title,

So if this doesn't work, it must be a core bug that just hasn't been noticed before, since there were no palettes using labels in the default TCA.

#2 Updated by Jo Hasenau almost 5 years ago

HI Christopher - thanks for updating the description.

IMHO the whole palette should just be skipped when there are no visible fields available, This will remove the label and the surrounding containers then.ยด

I will take care of that while working on the labels for pages and tt_content.

But I guess we should make it a separate RFC,. since it is about PHP code of tceforms and not just TCA settings.

#3 Updated by Jo Hasenau almost 5 years ago

I tracked it down to the palette "item" --linebreak--

If there is a --linebreak-- left after removing excluded fields, the palette still gets rendered, since "count($parts) will still be true.

Attached patch solves this problem by checking if $parts contains only --linebreak-- item(s) and removing the palette completely as well for this case.

#4 Updated by Ernesto Baschny almost 5 years ago

Commited to trunk rev. 9189.

#5 Updated by Susanne Moog over 4 years ago

  • Target version deleted (4.5.0)

Also available in: Atom PDF