Bug #25100

Method includeMakeMenu() of class tslib_menu is deprecated but still used in the core

Added by Christian Kuhn over 4 years ago. Updated almost 2 years ago.

Status:Closed Start date:2011-02-19
Priority:Should have Due date:
Assigned To:- % Done:

100%
Category:- Spent time: -
Target version:-
TYPO3 Version:4.5 Is Regression:
PHP Version:5.3 Sprint Focus:
Complexity:

Description

Used in class tslib_menu method makeMenu()

(issue imported from #M17667)

Related issues

related to Core - Task #31461: The Big Cleanup 4.7 Resolved 2012-02-19 2012-02-20
related to LTS Smooth Migration - Task #49197: Check for 'Remove leftover deprecated stuff' Rejected 2013-06-17

Associated revisions

Revision 6290f64f
Added by Tolleiv Nietsch over 3 years ago

[BUGFIX] Remove menu type special.userdefined

The manual says that this type has been removed in 4.6 in favor of
userfunctions.
Besides that, the block makes use of includeMakeMenu(), which doesn't
exist anymore.
Therefore I'd say it's safe to remove the block.

Change-Id: I69b33894eff55a8eedd0b04448229a96f6a0d199
Fixes: #25100
Release: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8848
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Revision 9684bd7e
Added by Tolleiv Nietsch over 3 years ago

[BUGFIX] Remove menu type special.userdefined

The manual says that this type has been removed in 4.6 in favor of
userfunctions.
Besides that, the block makes use of includeMakeMenu(), which doesn't
exist anymore.
Therefore I'd say it's safe to remove the block.

Change-Id: I69b33894eff55a8eedd0b04448229a96f6a0d199
Fixes: #25100
Release: 4.7, 4.6
Reviewed-on: http://review.typo3.org/9911
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8848

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8848

#3 Updated by Tolleiv Nietsch over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/9911

#5 Updated by Tolleiv Nietsch over 3 years ago

  • Status changed from Under Review to Resolved

#6 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13914

#7 Updated by Alexander Opitz almost 2 years ago

  • Category deleted (Communication)
  • Status changed from Under Review to Closed
  • Target version deleted (0)

This issue was resolved in Master and 4.7. The 4.6 version was abandoned as out of support.

Also available in: Atom PDF