Task #25334
Remove global declarations inside methods
Status: | Closed | Start date: | 2011-03-16 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | - | % Done: | 100% |
|
Category: | - | Spent time: | - | |
Target version: | - | |||
TYPO3 Version: | 4.5 | Complexity: | ||
PHP Version: | Sprint Focus: |
Description
We still find many global declarations such as
global $TCA
global $BE_USER
etc.
inside Core. This should be changed to $GLOBALS['TCA'], $GLOBALS['BE_USER'] according to our CGL.
(issue imported from #M17961)
Related issues
Associated revisions
[TASK] Remove global declarations inside methods
Global declaration such as global $TCA or global $BE_USER should
be changed to $GLOBALS['TCA'], $GLOBALS['BE_USER'], ...
Change-Id: I68f801ff6934a7e16db78cb3f10d1c2b64aef351
Fixes: #25334
Reviewed-on: http://review.typo3.org/1446
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Christian Kuhn
Reviewed-by: Christian Kuhn
History
#1 Updated by Ernesto Baschny over 4 years ago
- Tracker changed from Bug to Task
- PHP Version deleted (
5.2)
#2 Updated by Xavier Perseguers over 4 years ago
- Status changed from New to Accepted
#3 Updated by Mr. Hudson over 4 years ago
Patch set 1 of change I68f801ff6934a7e16db78cb3f10d1c2b64aef351 has been pushed to the review server.
It is available at http://review.typo3.org/1446
#4 Updated by Mr. Hudson over 4 years ago
Patch set 2 of change I68f801ff6934a7e16db78cb3f10d1c2b64aef351 has been pushed to the review server.
It is available at http://review.typo3.org/1446
#5 Updated by Mr. Hudson over 4 years ago
Patch set 3 of change I68f801ff6934a7e16db78cb3f10d1c2b64aef351 has been pushed to the review server.
It is available at http://review.typo3.org/1446
#6 Updated by Mr. Hudson over 4 years ago
Patch set 4 of change I68f801ff6934a7e16db78cb3f10d1c2b64aef351 has been pushed to the review server.
It is available at http://review.typo3.org/1446
#7 Updated by Mr. Hudson over 4 years ago
Patch set 5 of change I68f801ff6934a7e16db78cb3f10d1c2b64aef351 has been pushed to the review server.
It is available at http://review.typo3.org/1446
#8 Updated by Mr. Hudson over 4 years ago
Patch set 6 of change I68f801ff6934a7e16db78cb3f10d1c2b64aef351 has been pushed to the review server.
It is available at http://review.typo3.org/1446
#9 Updated by Xavier Perseguers over 4 years ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Applied in changeset 3f159c3a690db3b9ebb7d279523f4809cd9cf28d.
#10 Updated by Xavier Perseguers over 3 years ago
- Status changed from Resolved to Closed
#11 Updated by Ernesto Baschny about 2 years ago
- Target version deleted (
1081)