Bug #25816: Improve error handling for invalid types - TYPO3.Flow - TYPO3 Forge

TYPO3 Flow Base Distribution TYPO3.Eel TYPO3.Flow TYPO3.Fluid TYPO3.Kickstart TYPO3.Welcome Packages Applications

Bug #25816

Improve error handling for invalid types

Added by Robert Lemke over 4 years ago. Updated almost 4 years ago.

Status:

Resolved

Start date:

2011-04-07

Priority:

Must have

Due date:

Assigned To:

Robert Lemke

% Done:

100%

Category:

Utility

Target version:

TYPO3 Flow Base Distribution - 1.0 beta 2

PHP Version:

Complexity:

Has patch:

Affected Flow version:

Description

After introducing the Utility\TypeHandling functions, an InvalidArgumentException is thrown if some @var annotation uses a wrong type (and certainly also if invalid types are used elsewhere). However, the exception doesn't (and can't) give any hint where the invalid type was declared.

We have two options to improve this:

1) let the TypeHandling functions return FALSE if the type could not be parsed and throw a proper exception in the calling method
2) let the calling method catch the TypeHandling exceptions and rethrow a better exception

I'm all for solution 1)

Associated revisions

Revision bdcb2420
Added by Robert Lemke almost 4 years ago

[BUGFIX] Type declaration errors give hint on root cause

The TypeHandling::parseType() function will now throw a more specific
exception which allows other code parts to display more meaningful
error messages if a variable type was declared wrongly.

Change-Id: I010378956d80b66824bf9012b24ca36a8031c562
Resolves: #25816