Task #25886

Clean up Request hierarchy and fix type hints

Added by Karsten Dambekalns over 4 years ago. Updated about 4 years ago.

Status:Resolved Start date:2011-04-11
Priority:Should have Due date:
Assigned To:Karsten Dambekalns % Done:

100%
Category:MVC
Target version:TYPO3 Flow Base Distribution - 1.0 beta 1
Sprint: Has patch:
PHP Version: Complexity:

Description

Currently we a hierarchy around RequestInterface like this:

RequestInterface
  + Request
  |   + Web\Request
  |       + Web\SubRequest
  + CLI\Request

This could be simplified by getting rid of Request and combining it into Web\Request.

Another issue are type hints. Some places say they return RequestInterface (e.g. the ControllerContext). This potentially leads to trouble, if one assumes Request is returned, as that has some methods not defined in RequestInterface.

Associated revisions

Revision 6a35bed3
Added by Karsten Dambekalns about 4 years ago

[!!!][TASK] Clean up MVC\Request hierarchy

The MVC\Request class was only extended by MVC\Web\Request any longer,
thus this change moves the code into Web\Request.

Change-Id: If8bb5f383f9204f9f7638292f6680ba86aca846b
Resolves: #25886

History

#1 Updated by Karsten Dambekalns about 4 years ago

  • Status changed from New to Accepted
  • Assigned To set to Karsten Dambekalns

#2 Updated by Karsten Dambekalns about 4 years ago

  • Target version set to 1.0 beta 1

#3 Updated by Karsten Dambekalns about 4 years ago

  • Status changed from Accepted to Under Review

A first change about cleaning up the hierarchy is up for review now.

#4 Updated by Mr. Hudson about 4 years ago

Patch set 2 of change If8bb5f383f9204f9f7638292f6680ba86aca846b has been pushed to the review server.
It is available at http://review.typo3.org/3067

#5 Updated by Karsten Dambekalns about 4 years ago

Karsten Dambekalns wrote:

A first change about cleaning up the hierarchy is up for review now.

Seems all fine, no changes needed.

#6 Updated by Mr. Hudson about 4 years ago

Patch set 3 of change If8bb5f383f9204f9f7638292f6680ba86aca846b has been pushed to the review server.
It is available at http://review.typo3.org/3067

#7 Updated by Mr. Hudson about 4 years ago

Patch set 4 of change If8bb5f383f9204f9f7638292f6680ba86aca846b has been pushed to the review server.
It is available at http://review.typo3.org/3067

#8 Updated by Karsten Dambekalns about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF