Bug #25906
Injection with settings use breaks
| Status: | Resolved | Start date: | 2011-04-12 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Object | |||
| Target version: | TYPO3 Flow Base Distribution - 1.0 beta 1 | |||
| PHP Version: | Complexity: | |||
| Has patch: | Affected Flow version: |
Description
If configuring injection in Objects.yaml and making use of settings for a factory there the generated proxy is broken, because it assumes $this->settings exists.
It should use the static object container to fetch settings instead.
Related issues
Associated revisions
[BUGFIX] Injection with factory settings is usable again
If configuring injection in Objects.yaml and making use of settings for
a factory there, the generated proxy is broken, because it assumes
$this->settings exists.
Instead we use the static object container to fetch settings now.
Fixes: #25906
Change-Id: I15f86cc651935dbe756f5b02a155b5ff14c5e668
[BUGFIX] Fix constructor setting injection for singletons
Change I15f86cc651935dbe756f5b02a155b5ff14c5e668 missed one spot for
setting injection in the ProxyClassBuilder.
This change also adds some additional functional tests for setting
injection.
Change-Id: Ie6310c9b1a01c879408c512c6808e8b9485cf744
Resolves: #25906
History
#1 Updated by Mr. Hudson over 4 years ago
Patch set 1 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available at http://review.typo3.org/1767
#2 Updated by Karsten Dambekalns over 4 years ago
- Status changed from Accepted to Under Review
#3 Updated by Mr. Hudson over 4 years ago
Patch set 2 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available at http://review.typo3.org/1767
#4 Updated by Mr. Hudson over 4 years ago
Patch set 3 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available at http://review.typo3.org/1767
#5 Updated by Mr. Hudson over 4 years ago
Patch set 4 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available at http://review.typo3.org/1767
#6 Updated by Karsten Dambekalns over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 888b03da80bfbd437909496a9b243fce6a902506.
#7 Updated by Christopher Hlubek about 4 years ago
- Status changed from Resolved to Under Review
- % Done changed from 100 to 80
I have to reopen this issue since constructor injection of settings wasn't fixed. I pushed a new change with additional functional tests.
#8 Updated by Mr. Hudson about 4 years ago
Patch set 1 of change Ie6310c9b1a01c879408c512c6808e8b9485cf744 has been pushed to the review server.
It is available at http://review.typo3.org/1933
#9 Updated by Christopher Hlubek about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 80 to 100
Applied in changeset 4fc6b9e401f07939a2cf00da5e2021a3b564acb6.