Task #26078
Enforce RouteParts to only return simple types
| Status: | Resolved | Start date: | 2011-04-18 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Bastian Waidelich | % Done: | 100% |
|
| Category: | MVC - Routing | |||
| Target version: | - | |||
| Sprint: | Has patch: | |||
| PHP Version: | Complexity: |
Description
After calling Route::matches(), Route::getMatchResults() must not contain objects. See #25801 for reasoning.
Additionally we should enforce that Route::getMatchingUri() always returns a string.
Related issues
Associated revisions
[+TASK] Enforce RouteParts to only return simple types
Requests should never contain objects (see #25801 for details).
Consequently the Router should not deal with objects either.
This is enforced by checking the result of RoutePart::resolves()
and RoutePart::matches().
Change-Id: I7cb6874314e00505cb5d5272a48b2c11d0a95c6e
Resolves: #26078
History
#1 Updated by Bastian Waidelich over 4 years ago
- Tracker changed from Bug to Task
- Subject changed from Routes should only return simple types to Enforce RouteParts to only return simple types
#2 Updated by Mr. Hudson over 4 years ago
Patch set 1 of change I7cb6874314e00505cb5d5272a48b2c11d0a95c6e has been pushed to the review server.
It is available at http://review.typo3.org/1650
#3 Updated by Mr. Hudson over 4 years ago
Patch set 2 of change I7cb6874314e00505cb5d5272a48b2c11d0a95c6e has been pushed to the review server.
It is available at http://review.typo3.org/1650
#4 Updated by Bastian Waidelich over 4 years ago
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Applied in changeset c3e79ace3b3498aa4060e5c7cecefdfaeef752e4.