Bug #26228
Remove obsolete safe_mode hacks from t3lib_div
| Status: | Closed | Start date: | 2011-04-24 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Christian Kuhn | % Done: | 100% |
|
| Category: | Default | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 4.6 | Is Regression: | ||
| PHP Version: | Sprint Focus: | |||
| Complexity: |
Description
t3lib_div::fixPermissions() and t3lib_div::mkdir() have a preg_replace to remove a trailing slash from a given directory: Some PHP functions like mkdir() fail with trailing slashes if safe_mode is on.
These hacks can be removed in 4.6.
Related issues
Associated revisions
[BUGFIX] Remove obsolete safe_mode hacks from t3lib_div
Remove code from t3lib_div::fixPermissions and t3lib_div::mkdir that remove
a trailing slash from a given directory. This was a workaraund for PHP functions
like mkdir, they fail with trailing slashes if safe_mode is on.
Additionally the according unit tests are cleaned up and completed.
Change-Id: I44b330a3542bfd172736b103feec895b46494346
Resolves: #26228
Related: #25332
Releases: 4.6
Reviewed-on: http://review.typo3.org/1713
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
History
#1 Updated by Mr. Hudson over 4 years ago
Patch set 1 of change I44b330a3542bfd172736b103feec895b46494346 has been pushed to the review server.
It is available at http://review.typo3.org/1713
#2 Updated by Mr. Hudson over 4 years ago
Patch set 2 of change I44b330a3542bfd172736b103feec895b46494346 has been pushed to the review server.
It is available at http://review.typo3.org/1713
#3 Updated by Susanne Moog over 4 years ago
- Status changed from New to Under Review
- Assigned To set to Christian Kuhn
#4 Updated by Christian Kuhn over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b6cdaeab313dbfc1b058a9c5a544ef8e18574c48.
#5 Updated by Xavier Perseguers over 3 years ago
- Status changed from Resolved to Closed
#6 Updated by Ernesto Baschny about 2 years ago
- Target version deleted (
1081)