Bug #27232

Create unit test for "Original Request must only be set if there is a validation error"

Added by Sebastian Kurfuerst about 4 years ago. Updated about 3 years ago.

Status:Closed Start date:2011-06-06
Priority:Should have Due date:
Assigned To:Robert Lemke % Done:

0%

Category:MVC
Target version:TYPO3 Flow Base Distribution - 1.1
PHP Version: Complexity:
Has patch:No Affected Flow version:FLOW3 1.0.0

Description

May 18 2011 [+BUGFIX] (MVC): Original Request must only be set if there
is a validation error
Change-Id: Ic2179e21b97da9ad3cd4e5685f85e961c36edc63

In the commit message you write "Then, the "Speaker Profile" of the
conference site is correctly filled out again.". Imagine that in the
changelog / release notes of the FLOW3 distribution – doesn't make a lot
of sense. Also this changeset cries for a unit test because the logic /
motivation behind setting the original request could be explained by
that test and secured at the same time.

History

#1 Updated by Sebastian Kurfuerst almost 5 years ago

  • Status changed from Accepted to New
  • Priority changed from Must have to Should have
  • Target version changed from 1.0 beta 1 to 1.0 beta 2

#2 Updated by Robert Lemke almost 4 years ago

  • Target version changed from 1.0 beta 2 to 1.0.0

#3 Updated by Robert Lemke almost 4 years ago

Will you manage to write this test for 1.0?

#4 Updated by Karsten Dambekalns almost 4 years ago

  • Target version deleted (1.0.0)

#5 Updated by Karsten Dambekalns almost 4 years ago

  • Affected Flow version set to FLOW3 1.0.0

#6 Updated by Karsten Dambekalns over 3 years ago

  • Status changed from New to Needs Feedback
  • Assigned To changed from Sebastian Kurfuerst to Robert Lemke
  • Target version set to 1.1
  • Has patch set to No

Robert, is this still a valid issue considering your MVC refactoring? Feel free to close, if not :)

#7 Updated by Robert Lemke about 3 years ago

  • Status changed from Needs Feedback to Closed

Also available in: Atom PDF