Bug #27250

Bug #25335: Make TYPO3 free of NOTICE errors

Get rid of error_reporting() at various places in the source

Added by Stefan Neufeind about 4 years ago. Updated 11 months ago.

Status:Resolved Start date:2011-06-06
Priority:Should have Due date:
Assigned To:- % Done:

100%
Category:- Spent time: -
Target version:-
TYPO3 Version:4.6 Is Regression:No
PHP Version: Sprint Focus:
Complexity:

Description

At several places we currently have:
error_reporting(E_ALL ^ E_NOTICE ^ E_DEPRECATED);

I'd suggest we should leave it up to the administrator if he wants TYPO3 to "mess" with his error_reporting or not. Currently things like E_NOTICE can't even be activated explicitly for testing.

We could have an error_reporting-setting in installtool and if this localconf-variable is set, we'll set error_reporting(). But it can also be explicitly not set. Migration from TYPO3 4.5 to 4.6 (as with forceCharset on the move 4.4 to 4.5) should be to automatically set this to E_ALL ^ E_NOTICE ^ E_DEPRECATED in upgrade-wizard.

It also would make working on #25335 (getting rid of E_NOTICE-errors in the core) a lot easier.

Associated revisions

Revision 6b307242
Added by Stefan Neufeind 11 months ago

[TASK] Remove error_reporting from thumbs.php

Change-Id: I0aab3f628325fb2db3276d5d6d9e878e6328be0f
Resolves: #27250
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32783
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 7cc52723
Added by Stefan Neufeind 11 months ago

[TASK] Remove error_reporting from thumbs.php

Change-Id: I0aab3f628325fb2db3276d5d6d9e878e6328be0f
Resolves: #27250
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/32785
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Chris topher about 4 years ago

  • Parent task set to #25335

#2 Updated by Alexander Opitz 11 months ago

  • Status changed from New to Needs Feedback
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.4)?

#3 Updated by Stefan Neufeind 11 months ago

We have error-reporting-settings meanwhile.

Searching across the current master-tree, besides testcases and some libs (adodb) what I found was:
typo3/thumbs.php
22:error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED));

typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php
296: error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED));

I expect in SystemEnvironmentBuilder it is needed? In thumbs.php maybe not since that uses the official bootstrapping?

#4 Updated by Alexander Opitz 11 months ago

Shouldn't typo3/thumbs.php not deprecate? ;-)

Anyway, it looks like it can be removed.

#5 Updated by Gerrit Code Review 11 months ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32783

#6 Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32783

#7 Updated by Gerrit Code Review 11 months ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32785

#8 Updated by Stefan Neufeind 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF