TYPO3 Flow Base DistributionPackagesApplications

Bug #2757

ClassFilter is not working on windows

Added by Malte Jansen over 6 years ago. Updated almost 5 years ago.

Status:Resolved Start date:2009-03-04
Priority:Must have Due date:
Assigned To:Bastian Waidelich % Done:

100%

Category:-
Target version:-

Description

Comparing the ClassName with the FileName does not work, because of non UnixStyledPaths in the

Class: AbstractTestRunner
Function: readDirectories($testcaseFilenames, $testsDirectoryIterator)
Just transform the Path to UnixStyled before the check.
$fileNameWithPath = \F3\FLOW3\Utility\Files::getUnixStylePath($testsDirectoryIterator->getPathname());
if (preg_match('/\/' . str_replace('\\', '\\/', $this->testcaseClassName) . '\.php/', $fileNameWithPath) === 1) {

Testing_2757_01.patch Magnifier (1.9 kB) Bastian Waidelich, 2009-03-16 16:58

Associated revisions

Revision 81a6a511
Added by Bastian Waidelich over 6 years ago

Testing: Replace backslashes by forward slashes in paths returned by directory iterator in order to make the test class filter work on windows. Resolves #2757
Testing: The checkbox "run Code Coverage Analysis" in web-based testrunner is shown even if Xdebug is not available but it is disabled. A tooltip makes clear that Xdebug is required. Resolves #3110

History

#1 Updated by Bastian Waidelich over 6 years ago

Attached is a patch that resolves the problem. It fixes two other issues that led to apache crashes on windows

#2 Updated by Bastian Waidelich over 6 years ago

  • Assigned To set to Bastian Waidelich
  • % Done changed from 0 to 80
  • Estimated time deleted (0.10)

#3 Updated by Bastian Waidelich over 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 80 to 100

Applied in changeset r2166.

Also available in: Atom PDF