Task #27613
Rename $omitSignalInformation to $passSignalInformation
| Status: | Resolved | Start date: | 2011-06-21 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | SignalSlot | |||
| Target version: | TYPO3 Flow Base Distribution - 1.0 beta 1 | |||
| Sprint: | Has patch: | |||
| PHP Version: | Complexity: |
Description
A flag that comes with double negation by default should be avoided, thus we should invert the name and meaning here.
Note: do we actually need this? If we keep it, maybe make the signal information an array, so it's easier to amend in the future? Currently the simple string with classname and method name is a little limited in expressiveness.
Associated revisions
[!!!][TASK] Change $omitSignalInformation in SignalSlot
The name has been changed to $passSignalInformation and meaning as well
as default have been inverted. If you were not using the flag, nothing
changes, if you were, you need to flip the flag.
Change-Id: Ie878157242fb76117b27ee9d23a4dda67b4b8d0d
Resolves: #27613
History
#1 Updated by Robert Lemke about 4 years ago
Karsten Dambekalns wrote:
A flag that comes with double negation by default should be avoided, thus we should invert the name and meaning here.
fine, make sure to check our projects for any occurrence ...
Note: do we actually need this? If we keep it, maybe make the signal information an array, so it's easier to amend in the future? Currently the simple string with classname and method name is a little limited in expressiveness.
But what other information could you imagine?
#2 Updated by Karsten Dambekalns about 4 years ago
- Status changed from Needs Feedback to Accepted
Ok, we'll leave the signal information as is, and only rename the parameter.
#3 Updated by Mr. Hudson about 4 years ago
- Status changed from Accepted to Under Review
Patch set 1 of change Ie878157242fb76117b27ee9d23a4dda67b4b8d0d has been pushed to the review server.
It is available at http://review.typo3.org/2935
#4 Updated by Mr. Hudson about 4 years ago
Patch set 2 of change Ie878157242fb76117b27ee9d23a4dda67b4b8d0d has been pushed to the review server.
It is available at http://review.typo3.org/2935
#5 Updated by Karsten Dambekalns about 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ea7b661955f18cb1a8d53812fdfd9d7bdd501a0f.