Bug #27989
Wrong check in our atomic writes code
Status: | Resolved | Start date: | 2011-07-08 | |
---|---|---|---|---|
Priority: | Must have | Due date: | ||
Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
Category: | Cache | |||
Target version: | TYPO3 Flow Base Distribution - 1.1 RC1 | |||
PHP Version: | Complexity: | |||
Has patch: | No | Affected Flow version: | FLOW3 1.0.0 |
Description
This is from Cache\Backend\FileBackend, similar stuff is patched into Doctrine's ProxyFactory:
if ($result === FALSE) throw new \TYPO3\FLOW3\Cache\Exception('The temporary cache file "' . $temporaryCacheEntryPathAndFilename . '" could not be written.', 1204026251); $i = 0; $cacheEntryPathAndFilename = $this->cacheDirectory . $entryIdentifier . $this->cacheEntryFileExtension; while (!rename($temporaryCacheEntryPathAndFilename, $cacheEntryPathAndFilename) && $i < 5) { $i++; } if ($result === FALSE) throw new \TYPO3\FLOW3\Cache\Exception('The cache file "' . $cacheEntryPathAndFilename . '" could not be written.', 1222361632);
The second check for $result is moot, because it's not set in the rename loop...
Related issues
Associated revisions
History
#1 Updated by Karsten Dambekalns almost 4 years ago
- Status changed from New to Accepted
- Assigned To set to Karsten Dambekalns
#2 Updated by Karsten Dambekalns almost 4 years ago
- Target version deleted (
1230)
#3 Updated by Karsten Dambekalns almost 4 years ago
- Affected Flow version set to FLOW3 1.0.0
#4 Updated by Karsten Dambekalns over 3 years ago
- Target version set to 1.1
- Has patch set to No
#5 Updated by Karsten Dambekalns over 3 years ago
- Target version changed from 1.1 to 1.0.3
#6 Updated by Gerrit Code Review over 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8786
#7 Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8787
#8 Updated by Karsten Dambekalns over 3 years ago
- Status changed from Under Review to Accepted
#9 Updated by Gerrit Code Review over 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8931
#10 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8931
#11 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8787
#12 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8931
#13 Updated by Karsten Dambekalns over 3 years ago
- Target version changed from 1.0.3 to 1.0.4
#14 Updated by Karsten Dambekalns over 3 years ago
- Target version changed from 1.0.4 to 1.0.5
#15 Updated by Karsten Dambekalns about 3 years ago
- Target version changed from 1.0.5 to 1.1 RC1
#16 Updated by Gerrit Code Review about 3 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12187
#17 Updated by Gerrit Code Review about 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12187
#18 Updated by Gerrit Code Review about 3 years ago
Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12398
#19 Updated by Karsten Dambekalns about 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100