Bug #28264

Feature #25397: Adding XLIFF support as the default format for translation

Wrong check for existance of translated label

Added by Steffen Gebert about 4 years ago. Updated about 2 years ago.

Status:Closed Start date:2011-07-17
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:- Spent time: -
Target version:-
TYPO3 Version:4.6 Is Regression:
PHP Version: Sprint Focus:
Complexity:

Description

While tslib_fe::getLL() checks the existance of a translated label with
isset(), language::getLLL() does this with a strict string comparison.
This is evaluated as TRUE, if the subkey is not set at all, which is an
unexpected behavior.

Thus check, whether the label was translated into the current language
using isset().


Related issues

precedes Core - Feature #20953: Add a warning for IE6 users in TYPO3 4.6 Closed 2011-07-18 2011-07-18

Associated revisions

Revision 1a9007b7
Added by Steffen Gebert about 4 years ago

[BUGFIX] Wrong check for existance of translated label

While tslib_fe::getLL() checks the existance of a translated label with
isset(), language::getLLL() does this with a strict string comparison.
This is evaluated as TRUE, if the subkey is not set at all, which is an
unexpected behavior.

Thus check, whether the label was translated into the current language
using isset().

Change-Id: I421d541d9aeaa2403052d212c7adba819a4e116f
Resolves: #28264
Releases: 4.6
Reviewed-on: http://review.typo3.org/3380
Reviewed-by: Xavier Perseguers
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

History

#1 Updated by Mr. Hudson about 4 years ago

Patch set 1 of change I421d541d9aeaa2403052d212c7adba819a4e116f has been pushed to the review server.
It is available at http://review.typo3.org/3380

#2 Updated by Tolleiv Nietsch about 4 years ago

  • Status changed from New to Under Review

#3 Updated by Steffen Gebert about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Xavier Perseguers over 3 years ago

  • Status changed from Resolved to Closed

#5 Updated by Ernesto Baschny about 2 years ago

  • Target version deleted (4.6.0-beta1)

Also available in: Atom PDF