Bug #28477

Method visibility filter does not work

Added by Christopher Hlubek about 4 years ago. Updated about 4 years ago.

Status:Resolved Start date:2011-07-26
Priority:Must have Due date:
Assigned To:Christopher Hlubek % Done:

100%
Category:AOP
Target version:-
PHP Version: Complexity:
Has patch: Affected Flow version:

Description

The method visibility filter is not doing anything (again). A wrong regexp match parses visibilities like "public " or "protected ". The check for valid visibilities inside the PointcutMethodNameFilter is uselesss, because it accepts the space behind the visibility.

There is also no real unit test for the parseDesignatorMethod method inside the PointcutExpressionParser and the functional test for protected methods had a wrong visibility (public instead of protected!).

Associated revisions

Revision 881be270
Added by Christopher Hlubek about 4 years ago

[BUGFIX] Fix method visibility filter

This change mainly fixes the parsing of the method visibility and adds
a unit test that tests the actual parsing. Also the functional test
for advices on protected methods is fixed to really target a
protected method. To enable the unit test to get filters from a
composite and as a performance improvement, a nested composite will
only be created if the operator is not "&&".

Change-Id: I66925ef9b482c1d0abe9334740567ced23352fe8
Resolves: #28477

History

#1 Updated by Mr. Hudson about 4 years ago

  • Status changed from New to Under Review

Patch set 1 of change I66925ef9b482c1d0abe9334740567ced23352fe8 has been pushed to the review server.
It is available at http://review.typo3.org/3726

#2 Updated by Christopher Hlubek about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF