Bug #28862

Inconsistent handling of roles as objects and strings in Account

Added by Christopher Hlubek almost 4 years ago. Updated over 2 years ago.

Status:Resolved Start date:2011-08-09
Priority:Should have Due date:
Assigned To:Rens Admiraal % Done:

100%
Category:Security
Target version:TYPO3 Flow Base Distribution - 2.1
PHP Version:5.3 Complexity:easy
Has patch:No Affected Flow version:FLOW3 1.0.0

Description

While the public methods of Account that deal with @Role@s use objects, account internally stores only the role identifiers as strings. This should be changed.

Related issues

related to TYPO3.Flow - Task #37451: Rework usage of Roles in the security framework Resolved 2012-05-23
related to TYPO3.Flow - Feature #27698: Roles should use an adequate data type to get persisted a... Resolved 2011-06-26
related to TYPO3.Flow - Bug #47229: System roles become namespaced in configuration manager Resolved 2013-04-15

Associated revisions

Revision f0776fb3
Added by Karsten Dambekalns over 2 years ago

[!!!][FEATURE] Handle roles consistently as objects

With this change roles are consistently used as objects.

To prevent naming conflicts between roles from different packages the
package key is added to the role names.

The handling of roles now is more strict and does not allow the use of
not configured (non-existent) roles anymore.

Roles are now referenced as real instances instead of their string
identifiers in models. Roles which were defined in policies are now
automatically mirrored to the RoleRepository (usually stored as a
table in a database).

The getRoles() method has been removed from TokenInterface.

Change-Id: I39f335baa01fbe9b883e98e85cb1f063bbaf5744
Resolves: #28862
Resolves: #43578
Related: #37451
Related: #27698
Releases: 2.0, master

Revision 28e52aa8
Added by Karsten Dambekalns over 2 years ago

[!!!][FEATURE] Handle roles consistently as objects

With this change roles are consistently used as objects.

To prevent naming conflicts between roles from different packages the
package key is added to the role names.

The handling of roles now is more strict and does not allow the use of
not configured (non-existent) roles anymore.

Roles are now referenced as real instances instead of their string
identifiers in models. Roles which were defined in policies are now
automatically mirrored to the RoleRepository (usually stored as a
table in a database).

The getRoles() method has been removed from TokenInterface.

Change-Id: I39f335baa01fbe9b883e98e85cb1f063bbaf5744
Resolves: #28862
Resolves: #43578
Related: #37451
Related: #27698
Releases: 2.0, master

Revision f71d9f1c
Added by Adrian Föder over 2 years ago

[BUGFIX] System roles don't get a package namespace

The role change I39f335baa01fbe9b883e98e85cb1f063bbaf5744
introduced the automatic prepend of the package namespace
where the role has been defined; except for system roles
which are at the moment Anonymous and Everybody.

For ACLs, however, the package namespace has been prepended
also for the system roles. This fixes that behavior.

Change-Id: Iba14a25254a8db2cc53c6d07d63baac02b546763
Fixes: #47229
Related: #28862
Releases: 2.0, master

Revision 5936bb55
Added by Adrian Föder over 2 years ago

[BUGFIX] System roles don't get a package namespace

The role change I39f335baa01fbe9b883e98e85cb1f063bbaf5744
introduced the automatic prepend of the package namespace
where the role has been defined; except for system roles
which are at the moment Anonymous and Everybody.

For ACLs, however, the package namespace has been prepended
also for the system roles. This fixes that behavior.

Change-Id: Iba14a25254a8db2cc53c6d07d63baac02b546763
Fixes: #47229
Related: #28862
Releases: 2.0, master

History

#1 Updated by Karsten Dambekalns almost 4 years ago

  • Affected Flow version set to FLOW3 1.0.0

#2 Updated by Robert Lemke over 3 years ago

  • Status changed from New to Accepted
  • Assigned To set to Robert Lemke
  • Target version set to 1.1 beta 1
  • PHP Version set to 5.3
  • Has patch set to No
  • Complexity set to easy

#3 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 beta 1 to 1.1

#4 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 to 1.1 RC1

#5 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 RC1 to 2.0 beta 1

#6 Updated by Rens Admiraal almost 3 years ago

  • Assigned To changed from Robert Lemke to Rens Admiraal

#7 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from Accepted to Under Review

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#8 Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#9 Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#10 Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#11 Updated by Gerrit Code Review almost 3 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#12 Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#13 Updated by Gerrit Code Review over 2 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#14 Updated by Gerrit Code Review over 2 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#15 Updated by Gerrit Code Review over 2 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#16 Updated by Gerrit Code Review over 2 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#17 Updated by Gerrit Code Review over 2 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#18 Updated by Gerrit Code Review over 2 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#19 Updated by Gerrit Code Review over 2 years ago

Patch set 15 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#20 Updated by Gerrit Code Review over 2 years ago

Patch set 16 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#21 Updated by Gerrit Code Review over 2 years ago

Patch set 17 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#22 Updated by Gerrit Code Review over 2 years ago

Patch set 18 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13868

#23 Updated by Karsten Dambekalns over 2 years ago

  • Target version changed from 2.0 beta 1 to 2.1

#24 Updated by Gerrit Code Review over 2 years ago

Patch set 19 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#25 Updated by Gerrit Code Review over 2 years ago

Patch set 20 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#26 Updated by Gerrit Code Review over 2 years ago

Patch set 21 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#27 Updated by Gerrit Code Review over 2 years ago

Patch set 22 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#28 Updated by Gerrit Code Review over 2 years ago

Patch set 23 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#29 Updated by Gerrit Code Review over 2 years ago

Patch set 24 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#30 Updated by Gerrit Code Review over 2 years ago

Patch set 25 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#31 Updated by Gerrit Code Review over 2 years ago

Patch set 26 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#32 Updated by Gerrit Code Review over 2 years ago

Patch set 27 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#33 Updated by Gerrit Code Review over 2 years ago

Patch set 28 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#34 Updated by Gerrit Code Review over 2 years ago

Patch set 29 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#35 Updated by Gerrit Code Review over 2 years ago

Patch set 30 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13868

#36 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19782

#37 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#38 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19782

#39 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF