Bug #29041
Enlarge on click does not work anymore for images
| Status: | Closed | Start date: | 2011-08-17 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Patrick Broens | % Done: | 100% |
|
| Category: | Frontend | Spent time: | - | |
| Target version: | 4.6.0-beta2 | |||
| TYPO3 Version: | 4.6 | Is Regression: | ||
| PHP Version: | 5.3 | Sprint Focus: | ||
| Complexity: |
Description
Problem:
The javascript function openPic is not added anymore to the page when "Enlarge on click" is enabled for images in the cObj "Text with images" or "Images".
Solution:
After a lookup it seems in #27983 (Remove deprecated parts marked for removal) too much was removed.
$GLOBALS['TSFE']->additionalJavaScript
was never rendered anymore and is used to add javascript function openPic to the page, when "Enlarge to click" is enabled
How to reproduce:
Add content object "Images" to a page, add an image to it and enable "Enlarge to click". Not a popup but a new tab will open.
Associated revisions
[BUGFIX] Enlarge on click for images does not open a popup
With issue #27983 some deprecated parts were removed but obviously too much. Although $GLOBALS['TSFE']->additionalJavascript is used throughout the core, after this issue it was never rendered anymore in the frontend.
The javascript function openPic was never added to the frontend because of this.
This patch reinstates the responsible lines which were removed for Enlarge on click
Change-Id: I8e182be8e894e49212a5a4249118b44c0e0bd954
Resolves: #29041
Releases: 4.6
Reviewed-on: http://review.typo3.org/4392
Tested-by: Soren Malling
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
History
#1 Updated by Mr. Hudson almost 4 years ago
Patch set 1 of change I8e182be8e894e49212a5a4249118b44c0e0bd954 has been pushed to the review server.
It is available at http://review.typo3.org/4392
#2 Updated by Susanne Moog almost 4 years ago
- Status changed from New to Under Review
#3 Updated by Patrick Broens almost 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8577bd35af8c29de2c071b0600ff0fc17815cb55.
#4 Updated by Xavier Perseguers over 3 years ago
- Status changed from Resolved to Closed