Bug #29419: It is impossible to use the Collection interface in "type hints" - TYPO3.Flow - TYPO3 Forge

TYPO3 Flow Base Distribution TYPO3.Eel TYPO3.Flow TYPO3.Fluid TYPO3.Kickstart TYPO3.Welcome Packages Applications

Bug #29419

It is impossible to use the Collection interface in "type hints"

Added by Karsten Dambekalns almost 4 years ago. Updated almost 4 years ago.

Status:

Resolved

Start date:

2011-09-01

Priority:

Should have

Due date:

Assigned To:

Karsten Dambekalns

% Done:

Category:

Utility

Target version:

TYPO3 Flow Base Distribution - 1.0 beta 2

PHP Version:

Complexity:

Has patch:

Affected Flow version:

Description

Currently it is not possible to use the Collection interface for @param or @var annotations, because the TypeHandling doesn't consider it a valid collection type. For the sake of decoupling it should be possible to do so, though.

Related issues

Associated revisions

Revision cb1ff889
Added by Karsten Dambekalns almost 4 years ago

[BUGFIX] Allow use of the Collection interface in "type hints"

In type hints as well as @var and @param annotations it is better to
use the Collection interface instead of concrete implementations like
ArrayCollection. This was not possible so far.

This changes makes it possible to use Collection instead. When FLOW3 has
to create an instance for Collection, it will create an ArrayCollection.

Change-Id: I7edbaee97932469018ec89e640bfed10d4d54252
Fixes: #29419

History

#1 Updated by Mr. Hudson almost 4 years ago

Status changed from Accepted to Under Review

Patch set 1 of change I7edbaee97932469018ec89e640bfed10d4d54252 has been pushed to the review server.
It is available at http://review.typo3.org/4727

#2 Updated by Karsten Dambekalns almost 4 years ago

Status changed from Under Review to Closed

Ok, I didn't realize we had this one when creating #29419 - refer to that one for actual progress on this issue.

#3 Updated by Karsten Dambekalns almost 4 years ago

Status changed from Closed to Under Review

Why was this one closed?

Edit: it seems stupid as I ask this, after having seemingly closed this issue myself. I did not, here is what happened: I commented on and closed #27825, only to come back here and see it closed and with the same comment as well. Go figure...