Bug #29498
Disable compression for JS inline code in Backend
| Status: | Resolved | Start date: | 2011-09-05 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | Backend User Interface | Spent time: | - | |
| Target version: | 4.6.0-beta3 | |||
| TYPO3 Version: | 4.6 | Is Regression: | ||
| PHP Version: | Sprint Focus: | |||
| Complexity: |
Description
JSMin is a major performance nightmare and no network connection can be as slow as it would justify to spend so much time to execute JSmin several times for each and every backend request.
As long as we have no fast replacement in core available, disable compression for all JS snippets added with t3lib_PageRenderer::addJsInlineCode in the Backend.
callgraph-before.png (1.5 MB)
callgraph-after.png (1.7 MB)
profiling-before.html
- Profiler output
(71.3 kB)
Related issues
Associated revisions
[TASK] Disable compression for inlineJs in Backend
JSMin is a major performance nightmare and no network connection can be
as slow as it would justify to spend so much time to execute JSmin
several times for each and every backend request.
As long as we have no fast replacement in core available, disable
compression for all JS snippets added with
t3lib_PageRenderer::addJsInlineCode in the Backend.
JSMin's share of execution time was about 20-25% of the page generation
time, for almost empty backend pages even ~50%.
Change-Id: I5623ad6c8b9d24777b6bcf46ea97bf51eb9c62d3
Resolves: #29498
[TASK] Disable compression for inlineJs in Backend
JSMin is a major performance nightmare and no network connection can be
as slow as it would justify to spend so much time to execute JSmin
several times for each and every backend request.
As long as we have no fast replacement in core available, disable
compression for all JS snippets added with
t3lib_PageRenderer::addJsInlineCode in the Backend.
JSMin's share of execution time was about 20-25% of the page generation
time, for almost empty backend pages even ~50%.
Change-Id: I5623ad6c8b9d24777b6bcf46ea97bf51eb9c62d3
Resolves: #29498
Reviewed-on: http://review.typo3.org/4778
Reviewed-by: Xavier Perseguers
Reviewed-by: Björn Pedersen
Tested-by: Björn Pedersen
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
[TASK] Disable compression for inlineJs in Backend
JSMin is a major performance nightmare and no network connection can be
as slow as it would justify to spend so much time to execute JSmin
several times for each and every backend request.
As long as we have no fast replacement in core available, disable
compression for all JS snippets added with
t3lib_PageRenderer::addJsInlineCode in the Backend.
JSMin's share of execution time was about 20-25% of the page generation
time, for almost empty backend pages even ~50%.
Change-Id: Iabbd092a349dec6e84c40b7b7c750bc718168d85
Resolves: #29498
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/7201
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Sebastian Fischer
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
History
#1 Updated by Steffen Gebert almost 4 years ago
- Category set to Backend User Interface
#2 Updated by Steffen Gebert almost 4 years ago
- File callgraph-before.png added
- File callgraph-after.png added
- File profiling-before.html added
#3 Updated by Mr. Hudson almost 4 years ago
Patch set 1 of change I5623ad6c8b9d24777b6bcf46ea97bf51eb9c62d3 has been pushed to the review server.
It is available at http://review.typo3.org/4778
#4 Updated by Steffen Gebert almost 4 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset f707256c20c517f02eaf5769e512e802a4988e5d.
