Bug #30584

setup command should not create account with same identifier twice

Added by Christian Müller almost 4 years ago. Updated over 3 years ago.

Status:Resolved Start date:2011-10-05
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:-
Target version:-

Description

Either setup command controller or account model itself should ensure uniqueness of accounts.

Simple to reproduce, just run:

./flow3 setup:createadministrator --identifier admin --password pass

multiple times and check DB contents.

Please comment about which option would be best (setting unique contraint in account model or checking the accountRepository in command controller), I can take care of the patch.


Related issues

related to TYPO3.Flow - Bug #32823: Make combination of Account identifier and authentication... Resolved 2011-12-23

Associated revisions

Revision d5b11a82
Added by Rens Admiraal over 3 years ago

[TASK] Prevent setup of duplicate admin accounts

Change-Id: I18810dcc5729fcddd63a396b2b719caed1e21113
Resolves: #30584

History

#1 Updated by Regine Rosewich almost 4 years ago

If a valueObject would be possible, that would be the best solution. Otherwise a unique constraint would be the simplest solution.

#2 Updated by Sebastian Kurfuerst over 3 years ago

  • Assigned To set to Christian Müller

I think setting unique constraint in account model makes perfect sense.

#3 Updated by Christian Müller over 3 years ago

  • Assigned To deleted (Christian Müller)

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7290

#5 Updated by Rens Admiraal over 3 years ago

  • Status changed from New to Under Review

#6 Updated by Sebastian Kurfuerst over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF