Bug #31061: defective and maybe obsolete is_link() mirror function - TYPO3.Flow - TYPO3 Forge

TYPO3 Flow Base Distribution TYPO3.Eel TYPO3.Flow TYPO3.Fluid TYPO3.Kickstart TYPO3.Welcome Packages Applications

Bug #31061

defective and maybe obsolete is_link() mirror function

Added by Adrian Föder almost 4 years ago. Updated almost 4 years ago.

Status:

Resolved

Start date:

2011-10-18

Priority:

Must have

Due date:

Assigned To:

Bastian Waidelich

% Done:

100%

Category:

Utility

Target version:

TYPO3 Flow Base Distribution - 1.0.0

PHP Version:

Complexity:

Has patch:

Affected Flow version:

Description

in \TYPO3\FLOW3\Utility\Files the function is_link is defective. The function returns

return $normalizedPathAndFilename !== $normalizedTargetPathAndFilename

in my concrete case the both variables had the values

c:/users/afoeder/phpstormprojects/[...]/flow3/data/temporary/development/cache/data/flow3_monitor/
c:/users/afoeder/phpstormprojects/[...]/flow3/data/temporary/development/cache/data/flow3_monitor

(note the trailing slash at the first one, $normalizedPathAndFilename). This leads to an incorrect function result and therefore ::emptyDirectoryRecursively does not work because it's relying on that function.

Anyhow, this function is a wrapper because of a bug; see the annotation If http://bugs.php.net/bug.php?id=51766 gets fixed we can drop this.
This seems fixed, hence the function could be removed and usages can be renamed to the native is_link() function.

Associated revisions

Revision b306b18a
Added by Bastian Waidelich almost 4 years ago

[BUGFIX] make is_link() work around work for paths with trailing slash

On Windows \TYPO3\FLOW3\Utility\Files::is_link() compares the
given path with the resolved absolute path due to a bug in the
native is_link() implementation.
This fails if the given path ends on a slash because that is
stripped of by PHPs realpath() function.
This change strips of any trailing slash before comparing the
paths.

Change-Id: I94c53b5fe8dda82c05690cf02286091672d0650e
Resolves: #31061

History

#1 Updated by Robert Lemke almost 4 years ago

Target version changed from 1.0.0 to 1230

#2 Updated by Karsten Dambekalns almost 4 years ago

Status changed from New to Needs Feedback

Bastian, can you confirm this?

#3 Updated by Bastian Waidelich almost 4 years ago

Assigned To set to Bastian Waidelich

Unfortunately on PHP 5.3.5 (on Windows 7 @ 64bit) neither is_link() nor SplFileInfo::isLink() work correctly..
Steps to reproduce:
- Create a file "test.php":

1$linkPathAndFilename = __DIR__ . DIRECTORY_SEPARATOR . 'link.php';
2symlink(__FILE__, $linkPathAndFilename);
3
4var_dump(is_link($linkPathAndFilename));
5
6$fileInfo = new SplFileInfo($linkPathAndFilename);
7var_dump($fileInfo->isLink());