Bug #31070

Symlink related Unit Tests fail on some Windows systems

Added by Bastian Waidelich almost 4 years ago. Updated over 3 years ago.

Status:Resolved Start date:2011-10-18
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

100%
Category:- Testing -
Target version:-
PHP Version: Complexity:
Has patch: Affected Flow version:FLOW3 1.0.0

Description

Depending on the system configuration and the current Windows Username, the PHP function sys_get_temp_dir() returns an abbreviated path to the temporary directory.
Details: By default, this function returns C:\Windows\TEMP for me. But running the unit tests from CLI, it returns C:\Users\BWAIDEL~1\AppData\Local\Temp\ - That breaks our \TYPO3\FLOW3\Utitlity\Files::is_link() work around.

To fix this, we should use realpath(sys_get_temp_dir()) or tempnam() instead.

Associated revisions

Revision 60b45d7d
Added by Bastian Waidelich over 3 years ago

[BUGFIX] Symlink related Unit Tests fail on some Windows systems

This replaces sys_get_temp_dir() by tempnam() in unit tests that
use symlinks to avoid them from failing on some Windows
environments.

Change-Id: I6e59ec224d6c3a3c6f62180be334d3b76d1d067d
Resolves: #31070
Release: 1.0, 1.1

Revision 4c9bcc0b
Added by Bastian Waidelich over 3 years ago

[BUGFIX] Symlink related Unit Tests fail on some Windows systems

This replaces sys_get_temp_dir() by tempnam() in unit tests that
use symlinks to avoid them from failing on some Windows
environments.

Change-Id: I22bc69aed663caf8b1aa5939a8584c6f7be0a0f2
Fixes: #31070
Release: 1.0, 1.1

History

#1 Updated by Bastian Waidelich almost 4 years ago

  • Subject changed from File based Unit Rests fail on some Windows systems to Symlink related Unit Tests fail on some Windows systems

#2 Updated by Mr. Hudson almost 4 years ago

  • Status changed from Accepted to Under Review

Patch set 1 of change I6e59ec224d6c3a3c6f62180be334d3b76d1d067d has been pushed to the review server.
It is available at http://review.typo3.org/5967

#3 Updated by Mr. Hudson almost 4 years ago

Patch set 2 of change I6e59ec224d6c3a3c6f62180be334d3b76d1d067d has been pushed to the review server.
It is available at http://review.typo3.org/5967

#4 Updated by Karsten Dambekalns almost 4 years ago

  • Affected Flow version set to FLOW3 1.0.0

#5 Updated by Mr. Hudson over 3 years ago

Patch set 3 of change I6e59ec224d6c3a3c6f62180be334d3b76d1d067d has been pushed to the review server.
It is available at http://review.typo3.org/5967

#6 Updated by Mr. Hudson over 3 years ago

Patch set 4 of change I6e59ec224d6c3a3c6f62180be334d3b76d1d067d has been pushed to the review server.
It is available at http://review.typo3.org/5967

#7 Updated by Bastian Waidelich over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF