Bug #31189

Make TextareaViewHelper HTML5 aware

Added by rottenrice no-lastname-given almost 4 years ago. Updated about 3 years ago.

Status:Resolved Start date:2011-10-22
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

100%

Category:ViewHelpers
Target version:TYPO3 Flow Base Distribution - 1.1
Has patch:No Affected Flow version:Git 1.0

Description

1. the code example seems to be deprecated. "rows" and "cols" are required attributes but are not used in the example.

2. i suggest to use "rows" and "cols" as optional attributes. in html5 they are no longer tagged as required. furthermore you want to set the width and height of a textarea in css instead of using an html attribute ...

links:
http://api.typo3.org/fluid/master/class-Tx_Fluid_ViewHelpers_Form_TextareaViewHelper.html
http://www.w3.org/TR/html5/the-button-element.html#the-textarea-element

Associated revisions

Revision a5752cfd
Added by Bastian Waidelich about 3 years ago

[BUGFIX] Make TextareaViewHelper HTML5 aware

This makes the arguments "rows" and "cols" of the form.textarea
ViewHelper optional.

Change-Id: Ia94a66ab4ee33e75aa789e040d9746dde2191fff
Fixes: #31189
Releases: 1.1, 1.2

Revision 2ed20916
Added by Bastian Waidelich about 3 years ago

[BUGFIX] Make TextareaViewHelper HTML5 aware

This makes the arguments "rows" and "cols" of the form.textarea
ViewHelper optional.

Change-Id: Ia94a66ab4ee33e75aa789e040d9746dde2191fff
Fixes: #31189
Releases: 1.1, 1.2

History

#1 Updated by Bastian Waidelich over 3 years ago

  • Tracker changed from Task to Feature
  • Subject changed from TextareaViewHelper to Make TextareaViewHelper HTML5 aware
  • Status changed from New to Accepted
  • Assigned To set to Bastian Waidelich
  • Target version set to 1.1

#2 Updated by Bastian Waidelich about 3 years ago

  • Target version deleted (1.1)

#3 Updated by Bastian Waidelich about 3 years ago

  • Tracker changed from Feature to Bug
  • Target version set to 1.1
  • Affected Flow version set to Git 1.0

#4 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13076

#5 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13076

#6 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/13077

#7 Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13076

#8 Updated by Karsten Dambekalns about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF