Bug #31270
Proxy classes loose @return and @throws annotations
| Status: | Resolved | Start date: | 2011-10-25 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Object | |||
| Target version: | TYPO3 Flow Base Distribution - 1.0.1 | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | FLOW3 1.0.0 |
Description
The proxy classes built by FLOW3 no longer contain @throws and @return annotations. This breaks code relying on that, like the SOAP WSDL generator.
Related issues
Associated revisions
[BUGFIX]Â Proxy class builder should retain original annotations
Original metadata information on proxied methods should be retained
to allow for code inspection and usage of metadata for dynamic code
generation.
Change-Id: Ifcf5da2e4b43b917a85a1bea061e9ee8b33f1a50
Fixes: #31270
Releases: 1.0, 1.1
[BUGFIX] Proxy class builder should retain original annotations
Original metadata information on proxied methods should be retained
to allow for code inspection and usage of metadata for dynamic code
generation.
Change-Id: I9e68c42a227d6a978b74174cf02cd5940781b864
Fixes: #31270
Releases: 1.0, 1.1
History
#1 Updated by Mr. Hudson almost 4 years ago
- Status changed from Accepted to Under Review
Patch set 4 of change Ifcf5da2e4b43b917a85a1bea061e9ee8b33f1a50 has been pushed to the review server.
It is available at http://review.typo3.org/6163
#2 Updated by Christopher Hlubek almost 4 years ago
Just a note: this breaks ignorevalidation on controllers since they are still using getMethodTagsValues which will return a wrong result if an annoation is written by the proxy builder like:
@TYPO3\FLOW3\Annotations\IgnoreValidation(argumentName="$service")
instead of
@TYPO3\FLOW3\Annotations\IgnoreValidation("$service")
I'll push a bugfix for the ActionController.
#3 Updated by Karsten Dambekalns almost 4 years ago
Christopher Hlubek wrote:
I'll push a bugfix for the ActionController.
Thanks!
#4 Updated by Mr. Hudson over 3 years ago
Patch set 1 of change I9e68c42a227d6a978b74174cf02cd5940781b864 has been pushed to the review server.
It is available at http://review.typo3.org/6571
#5 Updated by Christopher Hlubek over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 72dd3de06a8f6bcc7f26e83b8e4f29c04edb36d6.