Bug #32049
Check for stripped comments not working
| Status: | Resolved | Start date: | 2011-11-24 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Core | |||
| Target version: | TYPO3 Flow Base Distribution - 1.0.2 | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | FLOW3 1.0.1 |
Description
The bootstrap checks for the presence of doc comments, to avoid problems with some bytecode caches that strip comments.
That check is not working correctly (FALSE is returned but the check expects an empty string). In case an error is seen, the exception cannot be thrown as well (no classloader available at that point).
Associated revisions
[BUGFIX] Fix check for stripped comments
The bootstrap checks for the presence of doc comments, to avoid
problems with some bytecode caches that strip comments.
That check did not work correctly (FALSE is returned but the check
expects an empty string). In case an error is seen, the exception
cannot be thrown as well (no classloader available at that point).
That exception issue has been been fixed for another check as well.
On top of this the check for magic_quotes_gpc has been adjusted a
tiny bit.
Change-Id: I61970255d8f4a8e1bd98431405fc39106c884e1d
Fixes: #32049
Releases: 1.0, 1.1
[BUGFIX] Fix check for stripped comments
The bootstrap checks for the presence of doc comments, to avoid
problems with some bytecode caches that strip comments.
That check did not work correctly (FALSE is returned but the check
expects an empty string). In case an error is seen, the exception
cannot be thrown as well (no classloader available at that point).
That exception issue has been been fixed for another check as well.
On top of this the check for magic_quotes_gpc has been adjusted a
tiny bit.
Change-Id: I23bb1e88ea153b11583ed0768f1de4f31c8da717
Fixes: #32049
Releases: 1.0, 1.1
History
#1 Updated by Mr. Jenkins over 3 years ago
Patch set 1 of change I23bb1e88ea153b11583ed0768f1de4f31c8da717 has been pushed to the review server.
It is available at http://review.typo3.org/6888
#2 Updated by Karsten Dambekalns over 3 years ago
- Status changed from Accepted to Under Review
#3 Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/7173
#4 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6888
#5 Updated by Karsten Dambekalns over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset acf8f34c16ff294ef2992fbecc0fa604c120b2e3.