Bug #32499

setfilepermissions doesn't work with ACL correctly

Added by Karsten Dambekalns over 3 years ago. Updated over 3 years ago.

Status:Resolved Start date:2011-12-13
Priority:Must have Due date:
Assigned To:Karsten Dambekalns % Done:

100%

Category:Core
Target version:TYPO3 Flow Base Distribution - 1.0.2
PHP Version: Complexity:nightmare
Has patch:No Affected Flow version:FLOW3 1.0.1

Description

After setting up fresh, the set file permissions didn't work correctly.

Associated revisions

Revision 0d403530
Added by Karsten Dambekalns over 3 years ago

[BUGFIX] ACL file permissions do not work correctly

When setting file permissions the setting of ACL would succeed but
the set permissions did not work as expected. This changes fixes that.

In addition it makes the calls in a chain so that the check for the
return value of the chmod commands is more robust. The directories
that are created are now always owned by the command line user.

Change-Id: I02d48e7cec54c374697ec6142ecbde69c666dcec
Fixes: #32499
Releases: 1.0, 1.1

Revision 9ae0f937
Added by Karsten Dambekalns over 3 years ago

[BUGFIX] ACL file permissions do not work correctly

When setting file permissions the setting of ACL would succeed but
the set permissions did not work as expected. This changes fixes that.

In addition it makes the calls in a chain so that the check for the
return value of the chmod commands is more robust. The directories
that are created are now always owned by the command line user.

Change-Id: I19bb0acf0bdcf50b10ba3c3397c0a4d62e305e21
Fixes: #32499
Releases: 1.0, 1.1

History

#1 Updated by Karsten Dambekalns over 3 years ago

ACL inheritance works like with classic unix permissions: inherited ACL entries are set like the setgid bit when a new entry is created. Thus for existing stuff ACL entries must be set with +ai. Plus there is a subtle difference between delete and delete_child when inheritance is involved.

#2 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7239

#3 Updated by Karsten Dambekalns over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/7245

#5 Updated by Karsten Dambekalns over 3 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF