Bug #32552
PackageStates are saved on each request
| Status: | Resolved | Start date: | 2011-12-14 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Robert Lemke | % Done: | 100% |
|
| Category: | Package | |||
| Target version: | - | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | Git master |
Description
\TYPO3\FLOW3\Package\PackageManager::initialize() always invokes loadPackageStates() which contains the lines
if ($this->packageStatesConfiguration === array() && $this->bootstrap->getContext() !== 'Production') {
$this->scanAvailablePackages();
[...]
scanAvailablePackages() in turn calls savePackageStates() which deletes all shortcut paths and recreates them.
If I get it right this means, that all shortcut paths are recreated for each request. Is this intended?
Related issues
Associated revisions
[BUGFIX] Update package states only when needed
While scanning of available packages will still happen on every request
in non-production contexts, the package state will only be saved if
there has actually been a change.
Change-Id: If18f9c7edebd8206348bf848059b7c37075866c4
Releases: 1.1
Resolves: #32552
History
#1 Updated by Christopher Hlubek over 3 years ago
- Priority changed from Should have to Must have
I think this is a blocker for development, I always get permission problems when Shortcuts are removed etc.
I think there is a bug with the empty package state configuration triggering the reload /save on every request. We only need to scan packages on the first hit and then only if package relate actions are called (like activate / list etc.).
#2 Updated by Karsten Dambekalns over 3 years ago
- Status changed from New to Accepted
#3 Updated by Gerrit Code Review over 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7268
#4 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7268
#5 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7268
#6 Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7268
#7 Updated by Gerrit Code Review over 3 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7268
#8 Updated by Gerrit Code Review over 3 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7268
#9 Updated by Gerrit Code Review over 3 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7268
#10 Updated by Christopher Hlubek over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8634aaec568b3e4f58d24b5c2f7137260b9e682f.