Bug #32841
Access check on page nodes is broken
| Status: | Resolved | Start date: | 2011-12-27 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Rens Admiraal | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - |
Description
When a page node has accessRoles configured the $node->isAccessible() check in NodeController->showAction throws an error because the securityContext is not yet initialized. This should be fixed in a way which is only initializing the securityContext if really needed to prevent session initialization whenever possible.
Related issues
Associated revisions
[BUGFIX] Fix accessRole check on page nodes
Change the Node object so it has a separate method to
check if access restrictions are active. Besides that
we remove the thrown error as the $securityContext->hasRole()
takes care of the securityContext initialization if needed.
This fixes the securityContext not yet initialized error
in the Phoenix Frontend/NodeController->showAction() method.
Change-Id: Ia54f308b6a5fb4f841978fe6293a075037232467
Fixes: #32841
Releases: 1.0, 1.1
History
#1 Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7623
#2 Updated by Rens Admiraal over 3 years ago
- Status changed from New to Under Review
#3 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7623
#4 Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7684
#5 Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7685
#6 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7685
#7 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7684
#8 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7685
#9 Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7685
#10 Updated by Gerrit Code Review over 3 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7685
#11 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7684
#12 Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7684
#13 Updated by Rens Admiraal over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:8e59f8ccd48ab5cbb86666bd72ec9c792881368c.
#14 Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/8763
#15 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/8763
#16 Updated by Robert Lemke almost 3 years ago
- Project changed from Base Distribution to TYPO3.Neos