Bug #33010

Work Package #45020: Content Editing Stability and Features

Editing of HTML elements with javascript causes problems

Added by Rens Admiraal over 3 years ago. Updated 9 months ago.

Status:Closed Start date:2012-01-06
Priority:Should have Due date:
Assigned To:- % Done:

100%
Category:-
Target version:-

Description

When an HTML element with inline javascript is edited this fails because the script is executed. We should come up with some kind of concept for this.

inlineJSatHTML.png (48.6 kB) Adrian Föder, 2012-08-27 08:39

Related issues

related to TYPO3.Neos - Bug #52387: Inconsistent Handling of HTML-Tags in HTML-Elements Resolved 2013-09-30

Associated revisions

Revision 0ad32818
Added by Christoph Dähne almost 2 years ago

[BUGFIX] HTML editor should be able to edit inline JavaScript

  • shows inline java script correctly in html editor
  • inline java script is executed exactly once on apply
  • html added in inline editing is escaped
Think about:
  • if inline java script is broken, it breaks the backend

Change-Id: Ie037243bf69576a2d9ce6b5aac32847c761b1aa9
Resolves: #33010, #52387
Reviewed-on: https://review.typo3.org/24168
Reviewed-by: Jacob Floyd
Tested-by: Jacob Floyd
Reviewed-by: Sebastian Kurfuerst
Tested-by: Sebastian Kurfuerst

History

#1 Updated by Karsten Dambekalns about 3 years ago

  • Project changed from Base Distribution to TYPO3.Neos

#2 Updated by Adrian Föder almost 3 years ago

ah, maybe that's the issue I had... I have inline JS; and as soon as clicking the "HTML Editor" button on the right, the editor opens obviously empty, creating such an (empty) popup:

 1<div id="" class="popover t3-popover-fixed t3-ui active" style="top: 18px; left: 527px; position: fixed; z-index: 10090; display: block;">
 2    <div class="triangle left" style="top: 138px;"/>
 3    <div class="header">
 4        <div>HTML Editor</div>
 5    </div>
 6    <div class="content">
 7        <div class="aloha-block-do-not-deactivate t3-htmleditor-window"></div>
 8    </div>
 9</div>
10

At the same time, I get an JavaScript error "syntax error" ]]> at CSS.js line 182 (see attached file).

Maybe a protective invocation wrapper can be applied to inline JS functions, being only executed when NOT in that HTML editor context...

#3 Updated by Aske Ertmann over 2 years ago

  • Parent task set to #45020

#4 Updated by Christoph Dähne almost 2 years ago

Html-Editing has some more corner-cases regarding JavaScript:

  • JavaScript executed if HTML-Editor opened (already mentioned above)
  • Sometimes content not displayed in editor (or only partially)
  • Same display-behavior in content area

#5 Updated by Christoph Dähne almost 2 years ago

Also JavaScript should not be executed on Apply (before it is executed during the reload of the content area).

#6 Updated by Christoph Dähne almost 2 years ago

And the Cursor shall not be black.

#7 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24163

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24168

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24168

#10 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24168

#11 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24168

#12 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24168

#13 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24168

#14 Updated by Anonymous almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Aske Ertmann 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF