TYPO3.Fluid

In a FLOW3 app, I have a form that has fields that reference an Account object and the Party property on the account object. This works fine because when Fluid renders form fields it calls the addAdditionalIdentityPropertiesIfNeeded in the AbstractFormFieldViewHelper class, which adds hidden identity fields for the properties.

However, when any part of the form is invalid a mapping error is triggered. The form field viewhelper sees the mapping error and no longer adds the property identities, which leads to a situation where the user corrects the error in the form, only to have FLOW3 try to create new property objects.

The fix is simple, and I think it's a no-brainer. We need to change the conditional logic in the getValue method on the AbstractFormFieldViewHelper from this:


if ($this->hasArgument('value')) {
$value = $this->arguments['value'];
} elseif ($this->hasMappingErrorOccured()) {
$value = $this->getLastSubmittedFormData();
} elseif ($this->isObjectAccessorMode() && $this->viewHelperVariableContainer->exists('TYPO3\Fluid\ViewHelpers\FormViewHelper', 'formObject')) {
$this->addAdditionalIdentityPropertiesIfNeeded();
$value = $this->getPropertyValue();
}


To this:


if ($this->hasArgument('value')) {
$value = $this->arguments['value'];
} elseif ($this->hasMappingErrorOccured()) {
$this->addAdditionalIdentityPropertiesIfNeeded();
$value = $this->getLastSubmittedFormData();
} elseif ($this->isObjectAccessorMode() && $this->viewHelperVariableContainer->exists('TYPO3\Fluid\ViewHelpers\FormViewHelper', 'formObject')) {
$this->addAdditionalIdentityPropertiesIfNeeded();
$value = $this->getPropertyValue();
}


Notice that we've added the call to addAditionalIdentityPropertiesIfNeeded to the second section of the statement. Even if there's an error, we should still add identity properties, right?

If the change sound right, let me know and I'll submit a patch to gerrit.

Zach