Feature #33539

Append query arguments from RoutePart handlers

Added by Aske Ertmann over 3 years ago. Updated almost 2 years ago.

Status:Rejected Start date:2012-01-30
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

0%

Category:MVC - Routing
Target version:-
PHP Version:5.3 Complexity:medium
Has patch:No

Description

It would be nice if we could append query arguments from routepart handlers, e.g. a appendArguments method, where it would be possible to add other query parameters which aren't a part of the returned path. In Phoenix we need this for modules since the route part handler for modules creates a query string, which causes this problem: #33519. It would be better if it could just add some arguments, and all the logic about creating the querystring, removing empty values, converting objects to identifiers etc.


Related issues

related to TYPO3.Flow - Bug #33519: Route always appends a question mark even if the route al... Resolved 2012-01-29

Associated revisions

Revision dc3532f4
Added by Aske Ertmann over 3 years ago

[BUGFIX] Prevent Route class from appending an extra question mark

Change-Id: I965367962786ab1ba923dbaae304e0d02afdfdc1
Fixes: #33519
Related: #33539
Releases: 1.1

History

#1 Updated by Karsten Dambekalns about 3 years ago

  • Target version deleted (1.1)

#2 Updated by Bastian Waidelich almost 3 years ago

  • Status changed from New to Needs Feedback

Do we still need this for Neos?
I'm still a bit unsure about this approach..

#3 Updated by Aske Ertmann almost 3 years ago

I'd a missing feature for creating links inside modules at the moment. But since we've fixed recursive namespaced arguments with https://review.typo3.org/#/c/15261/, there are some stuff broking with the current custom module route part handlers, which I need to look into. And I would suggest not to do anything about this until I have found a new solution for the module route part handlers..

#4 Updated by Bastian Waidelich over 2 years ago

  • Status changed from Needs Feedback to On Hold

Aske Ertmann wrote:

[...] I would suggest not to do anything about this until I have found a new solution for the module route part handlers..

Ok, I put this on hold for now.

#5 Updated by Bastian Waidelich almost 2 years ago

  • Status changed from On Hold to Rejected

I close this for now (> 9 month on hold). Feel free to reopen if we need this

Also available in: Atom PDF