Bug #33562

FileBackend didnt use defaultLifetime if lifetime is null

Added by Mike Franke over 3 years ago. Updated over 3 years ago.

Status:Resolved Start date:2012-01-31
Priority:Should have Due date:
Assigned To:Karsten Dambekalns % Done:

100%

Category:Cache
Target version:TYPO3 Flow Base Distribution - 1.0.3
PHP Version: Complexity:
Has patch:No Affected Flow version:Git master

Description

FileBackend.php#L191

$expiryTime = ($lifetime === NULL) ? 0 : (time() + $lifetime);

should be

$lifetime = ($lifetime === NULL) ? $this->defaultLifetime : $lifetime;
$expiryTime = ($lifetime === 0) ? 0 : (time() + $lifetime);

Related issues

related to Core - Feature #39430: Update cache framework to latest FLOW3 version Resolved 2014-04-17

Associated revisions

Revision a0ee47d1
Added by Karsten Dambekalns over 3 years ago

[BUGFIX] Fix default lifetime use in cache backend

This fixes the FileBackend so it actually uses the default lifetime
in cases it should do that.

ArrayAccess detection for configuration in AbstractBackend is fixed
along the way and the RedisBackend code cleaned up a little.

Change-Id: Ia6a0c5f2a885cb68ee01302224c3d694e561be5f
Fixes: #33562
Releases: 1.0, 1.1

Revision f22d865d
Added by Karsten Dambekalns over 3 years ago

[BUGFIX] Fix default lifetime use in cache backend

This fixes the FileBackend so it actually uses the default lifetime
in cases it should do that.

ArrayAccess detection for configuration in AbstractBackend is fixed
along the way and the RedisBackend code cleaned up a little.

Change-Id: Id934e3b8f3d3b121924c46f70f0e27f92a7e658d
Fixes: #33562
Releases: 1.0, 1.1

History

#1 Updated by Karsten Dambekalns over 3 years ago

  • Status changed from New to Accepted
  • Assigned To set to Karsten Dambekalns

#2 Updated by Karsten Dambekalns over 3 years ago

  • Target version set to 1.0.3

#3 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8786

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8786

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/9037

#6 Updated by Karsten Dambekalns over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF