Bug #33569

AbstractFormFieldViewHelper always converts entities to identities

Added by Bastian Waidelich over 3 years ago. Updated over 3 years ago.

Status:Resolved Start date:2012-01-31
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

100%
Category:ViewHelpers
Target version:-
Has patch:No Affected Flow version:Git master

Description

AbstractFormFieldViewHelper::getValue() currently always tries to convert objects by calling PersistenceManager::getIdentifierByObject(). This makes it impossible for custom ViewHelpers to access the unmodified value.

Associated revisions

Revision 02f8a923
Added by Bastian Waidelich over 3 years ago

[BUGFIX] AbstractFormFieldViewHelper always converts entities

AbstractFormFieldViewHelper::getValue() currently always tries
to convert objects to identities by calling
PersistenceManager::getIdentifierByObject().
This makes it impossible for custom ViewHelpers to access the
unmodified value that was previously submitted (or bound to the
form field view helper).

This change introduces an argument $convertObjects that allows
experienced developers to disable this behavior in custom
view helpers.

Change-Id: I5326c9424cfecf7a78d9a0ea3c8044150f35bfe4
Fixes: #33569
Releases: 1.1

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8783

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8783

#3 Updated by Bastian Waidelich over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF