Bug #33719

.Shortcuts symlinks use absolute path

Added by Rens Admiraal over 3 years ago. Updated about 3 years ago.

Status:Closed Start date:2012-02-06
Priority:Should have Due date:
Assigned To:Rens Admiraal % Done:

100%

Category:Package
Target version:TYPO3 Flow Base Distribution - 1.1
PHP Version: Complexity:
Has patch:No Affected Flow version:Git master

Description

The symlinks in the .Shortcuts folder use absolute paths. This is an issue in chrooted environments where the path to the document root can be a different one then the path in the webserver process.

This causes the symlinks to be working in only one situation: during CLI execution or during a HTTP request, depending on which generated the symlink.


Related issues

related to TYPO3.Flow - Bug #37220: PackageStates.php uses absolute paths Resolved 2012-05-16

Associated revisions

Revision 1a688df6
Added by Rens Admiraal about 3 years ago

[BUGFIX] Save relative package path in PackageStates.php

Using absolute paths in the PackageStates.php causes problems in a
chroot environment where the absolute path is different in CLI then
in the HTTPD process.

Also relative paths allow to put PackageStates.php under version
control to maintain a specific state even when paths differ
on development and production systems.

Change-Id: Iac40024eee98182f67385f452ade2e1f2afed82d
Fixes: #37220
Related: #33719
Releases: 1.1, 1.2

Revision 531178a2
Added by Rens Admiraal about 3 years ago

[BUGFIX] Save relative package path in PackageStates.php

Using absolute paths in the PackageStates.php causes problems in a
chroot environment where the absolute path is different in CLI then
in the HTTPD process.

Also relative paths allow to put PackageStates.php under version
control to maintain a specific state even when paths differ
on development and production systems.

Change-Id: Iac40024eee98182f67385f452ade2e1f2afed82d
Fixes: #37220
Related: #33719
Releases: 1.1, 1.2

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#6 Updated by Bernhard Fischer over 3 years ago

The symlinks in the Web/_Resources/Static/Packages folder should also follow relative pathnames for an chrooted installation. Otherwise a cache warmup on CLI will lead to non-existing pathnames.

The usage of relative symlink creation should be done in general on non Windows systems. This also regards the PrivateResourcesPublishingAspect class, which uses absolute symlinks as well.

The unit test for Utilitys/Files.php still fails. I'd assume directory symlink removal is done by unlink() but it has to be done by rmdir() even if it is a symlink.

#7 Updated by Bastian Waidelich over 3 years ago

  • Project changed from TYPO3 Flow Base Distribution to TYPO3.Flow

#8 Updated by Bastian Waidelich over 3 years ago

  • Subject changed from .Shortcuts sumlinks use absolute path to .Shortcuts symlinks use absolute path
  • Category set to Package
  • Assigned To set to Rens Admiraal
  • Target version set to 1.1
  • Has patch set to No

#9 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#10 Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#11 Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#12 Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#13 Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#14 Updated by Gerrit Code Review over 3 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#15 Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#16 Updated by Gerrit Code Review over 3 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#17 Updated by Gerrit Code Review over 3 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#18 Updated by Gerrit Code Review over 3 years ago

Patch set 15 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#19 Updated by Gerrit Code Review over 3 years ago

Patch set 16 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#20 Updated by Gerrit Code Review over 3 years ago

Patch set 17 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#21 Updated by Gerrit Code Review over 3 years ago

Patch set 18 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#22 Updated by Gerrit Code Review over 3 years ago

Patch set 19 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#23 Updated by Gerrit Code Review over 3 years ago

Patch set 20 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#24 Updated by Gerrit Code Review over 3 years ago

Patch set 21 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#25 Updated by Gerrit Code Review over 3 years ago

Patch set 22 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8868

#26 Updated by Karsten Dambekalns about 3 years ago

  • Status changed from Under Review to Closed
  • % Done changed from 0 to 100

No more .Shortcuts in current master…

Also available in: Atom PDF