Bug #3404

Refactor ControllerContext to be built only before passing it to the View

Added by Sebastian Kurfuerst about 6 years ago. Updated almost 5 years ago.

Status:Resolved Start date:2009-05-21
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

100%
Category:MVC
Target version:TYPO3 Flow Base Distribution - 1.0 alpha 1
PHP Version: Complexity:
Has patch: Affected Flow version:

Description

$this->controllerContext should not be available in the Controller, but just be passed on to the View.

There is one question remaining: Should the URIHelper / URIBuilder get this whole object, or just the Request object?

Greets,
Sebastian

Associated revisions

Revision 7030ab49
Added by Bastian Waidelich about 6 years ago

FLOW3:
  • Removed FLOW3\Utility\GenericCollection from repository, it's currently not needed. Resolves #3400
  • Moved method setArgumentsFromRawRequestData() from Router to RequestBuilder. Resolves #3368
  • Renamed URIHelper to URIBuilder. Removed Classes HelperInterface, AbstractHelper and InvalidViewHelper Exception. Adapted AbstractView & ViewInterface. Resolves #3303
  • Added section parameter to URIFor() method of the URIBuilder
  • Refactored Base controllers - controllerContext is no instance variable anymore and will be created when passed to view in initializeView(). Resolves #3404
  • ControllerContext is of scope prototype now. Added setter/getter for URIBuilder. Some cosmetic changes.
  • Added getRequestPath() to Request.
  • ControllerKeys (@controller, @action, @package, @subpackage and @format) can now be set by request arguments. Resolves #2853

History

#1 Updated by Sebastian Kurfuerst about 6 years ago

  • Status changed from Accepted to New

#2 Updated by Bastian Waidelich about 6 years ago

  • Assigned To changed from Sebastian Kurfuerst to Bastian Waidelich

We decided to rename setupControllerContext() to buildControllerContext(). The instance variable $controllerContext will be removed from AbstractController.

#3 Updated by Bastian Waidelich about 6 years ago

There is one question remaining: Should the URIHelper / URIBuilder
get this whole object, or just the Request object?

The URIBuilder does not contain the controllerContext. The controllerContext contains an instance of URIBuilder.

#4 Updated by Bastian Waidelich about 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset r2344.

Also available in: Atom PDF